fix "No fortunes found" error when asking for non-existent cookies collections filenames

Author: shlomif

fortune-mod/fortune/fortune.c

@@ -1134,7 +1134,7 @@ static int form_file_list(char **files, int file_cnt)
                 }
                 else
                 {
-                    ret = 1;
+                    ret = 0;
                 }
             }
             else if (strncmp(fullpathname, locpathname, sizeof(fullpathname)) &&

fortune-mod/tests/t/test-fortune-percent.t

@@ -9,7 +9,7 @@ use lib "$FindBin::Bin/lib";
 use FortTestInst ();
 
 use Path::Tiny qw/ cwd path tempdir tempfile /;
-use Test::More tests => 9;
+use Test::More tests => 11;
 use Test::Trap
     qw( trap $trap :flow:stderr(systemsafe):stdout(systemsafe):warn );
 
@@ -35,6 +35,29 @@ use Test::Trap
         }
     }
 
+    {
+        my @cmd =
+            ( $inst_dir->child( 'games', 'fortune' ), "notexisttttttttttt" );
+
+        print "Running [@cmd]\n";
+        trap
+        {
+            system(@cmd);
+        };
+
+        {
+            # TEST
+            unlike( $trap->stdout(), qr/\S/ms, "No fortunes found", );
+
+            # TEST
+            like(
+                $trap->stderr(),
+                qr/\ANo fortunes found/ms,
+                "error message for No fortunes found",
+            );
+        }
+    }
+
     my @cmd = (
         $inst_dir->child( 'games', 'fortune' ),
         "999999999999999%", "songs-poems"