loosen overly restrictive dependencies #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martiansideofthemoon here are the dependency changes i mentioned to the pyproject.toml. It might be possible to further loosen the requirements, tough supporting
torch>2.0and getting rid of the mandatory install ofpysqlite-binarywas enough for my workflow. Since python already comes with a sqlite3 module, there's no need to enforce the use ofpysqlite-binary(which as I mentioned in Slack just failed to install for me due to a missing wheel on my platform). If someone does want it installed, they can do so withpip install factscore[pysqlite-binary]