Change VideoEffect from a Base Class to a Protocol

[RainyTunes]

I believe in the following code, the protocol-extension design is better than the class-heritage design.

Now:

open class VideoEffect {
    /// Creates an object instance.
    public init() {
    }

    /// Executes to apply a video effect.
    open func execute(_ image: CIImage, info: CMSampleBuffer?) -> CIImage {
        image
    }
}

how about:

protocol VideoEffectProtocol {
    func execute(_ image: CIImage, info: CMSampleBuffer?) -> CIImage
}

extension VideoEffectProtocol {
    /// Executes to apply a video effect.
    func execute(_ image: CIImage, info: CMSampleBuffer?) -> CIImage {
        image
    }
}

class CustomVideoEffect: VideoEffectProtocol {
   init() {
   }
   open func execute(_ image: CIImage, info: CMSampleBuffer?) -> CIImage {
        // do sth if need
        image
    }
}

It seems that they can provide the same functionality, while the protocol-based one is much more modern and flexible.

I would be honoured to create a PR myself if you agree with the idea.

[shogo4405]

I agree. However, as I am currently reviewing the design around here, I will take care of it myself.

[shogo4405]

The next 2.0.0 series will look something like this.

public protocol VideoEffect: AnyObject {
    /// Executes to apply a video effect.
    func execute(_ image: CIImage, info: CMSampleBuffer?) -> CIImage
}