Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine treatment of plan sequences #165

Open
rpgoldman opened this issue Feb 29, 2024 · 0 comments
Open

Refine treatment of plan sequences #165

rpgoldman opened this issue Feb 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@rpgoldman
Copy link
Contributor

The SHOP code is terribly confusing about what a "plan" is. Sometimes it's a list of actions interspersed with action costs. Sometimes those costs are removed (after a call to remove-costs). Sometimes it's only a list of normal actions (all internal actions -- prefixed with "!!" -- removed); you can get that with a call to shorter-plan).

Unfortunately, sometimes the shop code won't work if it has the wrong one of these, and the compiler can't help us find such errors.

I propose to add structure classes that wrap these different sequences and add function declarations that indicate which one of these various functions expect.

Inside SHOP3 proper everything is a full sequence (all actions, and costs) -- that code can remain untouched. But any code that manipulates a plan sequence should be fixed to a particular one of these structures, so that errors in plan-sequence manipulation (e.g., in plan-repair) can be caught by the compiler (at least SBCL's compiler) and fixed before run-time.

@rpgoldman rpgoldman added the enhancement New feature or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant