Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on style warning in test #17

Open
rpgoldman opened this issue Apr 11, 2019 · 2 comments
Open

Check on style warning in test #17

rpgoldman opened this issue Apr 11, 2019 · 2 comments

Comments

@rpgoldman
Copy link
Contributor

rpgoldman commented Apr 11, 2019

Running the tests on SBCL, I see this in the transcript:

 Running test METHOD-TESTS ..
WARNING: Condition STYLE-WARNING was signalled.

not yet sure what causes this, and the test still passes.

@rpgoldman
Copy link
Contributor Author

Also there are style warnings in TEST-FLAW-DETECTION, I believe.

@lispm
Copy link

lispm commented Apr 12, 2019

Style warnings, are just warnings. Not errors.

For example in the source code are lambda lists with &optional and &key. Example: (sexp &optional (stream t) &key (canonical nil)). There are other examples. The compiler tells the developer of a programming construct that represents what is thought to be bad programming style.

These kind of lambda lists are thought to be error-prone for programmers. They may forget to provide the optional argument when providing the keyword args. That's why there is a style warning.

SBCL also warns of uses of deprecated functions. In the code there is a call to sb-debug:backtrace. The compiler recommends to use sb-debug:print-backtrace instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants