Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit invoice/creditnote/expense/otherincome - tidy templates #1951

Open
shoulders opened this issue Sep 25, 2022 · 1 comment
Open

edit invoice/creditnote/expense/otherincome - tidy templates #1951

shoulders opened this issue Sep 25, 2022 · 1 comment

Comments

@shoulders
Copy link
Owner

shoulders commented Sep 25, 2022

  • remove payment details
    • this should not be required becasue as soon as a payment is made, you cannot edit the record
  • {if $invoice_details.status == 'pending' || $invoice_details.status == 'unpaid'}
    • in the edit template you can only edit if unused or pending - check this and then remove, i added and allo edit function check
  • all records shoudl have a checkRecordCanBeSubmitted() function and make the date checks common in general class
  • update functions for thesze records should not include finiancials execpt sales_tax_rate, recalcualte totals fixes this
  • check that qfrom new_value issue like on expenses does not plague submissions (could be casue by sales_tax_rate and bwing in a different tax system) this is the combobox and is normal
  • add submission checking to each
  • add placeholder prefill functions, the combo box is still waiting for input, could use later.
@shoulders shoulders added this to the 3.1.4 milestone Sep 25, 2022
@shoulders
Copy link
Owner Author

  • credit note = present
  • expense = present
  • otherincome = present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant