Skip to content

Replacing non-standard methods #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replacing non-standard methods #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions svg-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ const renderBody = (elem, options, body) => {

const isSpriteIcon = !!spriteIconId;
const parser = new DOMParser();
const doc = parser.parseFromString(body, "text/html");
const fragment = isSpriteIcon ? doc.getElementById(spriteIconId) : doc.querySelector("svg");
const doc = parser.parseFromString(body, "image/svg+xml");
const fragment = isSpriteIcon ? doc.getElementById(spriteIconId) : doc.documentElement;

const eventNames = getAllEventNames();

Expand Down Expand Up @@ -152,7 +152,8 @@ const renderBody = (elem, options, body) => {
});

// For a sprite we want to include the whole DOM of sprite element
elem.innerHTML = spriteIconId ? fragment.outerHTML : fragment.innerHTML;
const replacedContent = spriteIconId ? [fragment] : fragment.children;
elem.replaceChildren(...replacedContent);

// This code block basically merges attributes of the original SVG
// the SVG element where it is called from. For eg,
Expand Down Expand Up @@ -407,4 +408,4 @@ globalThis.SVGLoader.destroyCache = async () => {
localStorage.removeItem(key);
}
});
}
}