Add feature: Exclude authenticated user's notes from public notes list + unified newline character process

Author: davidwei

src/HappyNotes.Api/Controllers/NotesController.cs

@@ -29,7 +29,9 @@ public async Task<ApiResult<PageData<NoteDto>>> MyLatest(int pageSize, int pageN
     [EnforcePageSizeLimit(Constants.MaxPageSize)]
     public async Task<ApiResult<PageData<NoteDto>>> Latest(int pageSize, int pageNumber)
     {
-        var notes = await noteService.GetPublicNotes(pageSize, pageNumber);
+        // If the caller is authenticated currentUser.Id will be > 0; exclude their own notes to avoid showing them
+        long? excludeUserId = currentUser?.Id > 0 ? currentUser.Id : null;
+        var notes = await noteService.GetPublicNotes(pageSize, pageNumber, excludeUserId);
         return new SuccessfulResult<PageData<NoteDto>>(mapper.Map<PageData<NoteDto>>(notes));
     }
 

src/HappyNotes.Common/StringExtensions.cs

@@ -161,4 +161,28 @@ public static string RemoveNoteLinks(this string? text)
 
     [GeneratedRegex(@"<\s*(?!https?)([a-zA-Z]+)[^>]*>.*</\s*\1\s*>|<\s*(?!https?)([a-zA-Z]+)[^>]*/>", RegexOptions.IgnoreCase | RegexOptions.Singleline)]
     private static partial Regex HtmlTagPattern();
+
+    /// <summary>
+    /// Normalizes various newline formats to Unix-style LF (\n).
+    /// Handles Windows (CRLF), Unix (LF), old Mac (CR), and Unicode line separators.
+    /// </summary>
+    public static string NormalizeNewlines(this string? input)
+    {
+        if (string.IsNullOrEmpty(input))
+            return input ?? string.Empty;
+
+        // First, convert Windows CRLF (\r\n) to Unix LF (\n)
+        string result = input.Replace("\r\n", "\n");
+
+        // Then, convert any remaining CR (\r) to LF (\n) - handles old Mac format
+        result = result.Replace("\r", "\n");
+
+        // Replace Unicode Line Separator (U+2028) with a single newline (\n)
+        result = result.Replace("\u2028", "\n");
+
+        // Replace Unicode Paragraph Separator (U+2029) with a double newline (\n\n)
+        result = result.Replace("\u2029", "\n\n");
+
+        return result;
+    }
 }

src/HappyNotes.Repositories/NoteRepository.cs

@@ -50,8 +50,15 @@ public async Task<PageData<Note>> GetUserNotes(long userId, int pageSize, int pa
             n => n.CreatedAt, isAsc);
     }
 
-    public async Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber, bool isAsc = false)
+    public async Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber, bool isAsc = false, long? excludeUserId = null)
     {
+        if (excludeUserId.HasValue)
+        {
+            return await _GetPageDataAsync(pageSize, pageNumber,
+                n => n.DeletedAt == null && n.IsPrivate == false && n.UserId != excludeUserId.Value,
+                n => n.CreatedAt, isAsc);
+        }
+
         return await _GetPageDataAsync(pageSize, pageNumber,
             n => n.DeletedAt == null && n.IsPrivate == false,
             n => n.CreatedAt, isAsc);

src/HappyNotes.Repositories/interfaces/INoteRepository.cs

@@ -11,7 +11,7 @@ public interface INoteRepository : IRepositoryBase<Note>
     Task<PageData<Note>> GetUserTagNotes(long userId, string tag, int pageSize, int pageNumber, bool isAsc = false);
     Task<PageData<Note>> GetUserNotes(long userId, int pageSize, int pageNumber, bool includePrivate = false,
         bool isAsc = false);
-    Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber, bool isAsc = false);
+    Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber, bool isAsc = false, long? excludeUserId = null);
     Task<PageData<Note>> GetLinkedNotes(long userId, long noteId, int max = 100);
 
     Task<PageData<Note>> GetUserDeletedNotes(long userId, int pageSize, int pageNumber);

src/HappyNotes.Services/NoteService.cs

@@ -27,7 +27,7 @@ TimeProvider timeProvider
 {
     public async Task<long> Post(long userId, PostNoteRequest request)
     {
-        var fullContent = request.Content?.Trim() ?? string.Empty;
+        var fullContent = request.Content?.NormalizeNewlines().Trim() ?? string.Empty;
         if (string.IsNullOrEmpty(request.Content))
         {
             throw new ArgumentException("Nothing was submitted");
@@ -74,7 +74,7 @@ await longNoteRepository.InsertAsync(new LongNote
                 }
                 catch (Exception ex)
                 {
-                    logger.LogError(ex, "Failed to sync new note to service {ServiceType}, note ID: {NoteId}", 
+                    logger.LogError(ex, "Failed to sync new note to service {ServiceType}, note ID: {NoteId}",
                         syncNoteService.GetType().Name, note.Id);
                 }
             });
@@ -97,7 +97,7 @@ public async Task<bool> Update(long userId, long id, PostNoteRequest request)
         }
 
         var newNote = mapper.Map<PostNoteRequest, Note>(request);
-        var fullContent = request.Content ?? string.Empty;
+        var fullContent = (request.Content ?? string.Empty).NormalizeNewlines();
 
         // the following is a hack for user shukebeta only
         if (existingNote.UserId == 1 && fullContent.IsHtml())
@@ -147,7 +147,7 @@ public async Task<bool> Update(long userId, long id, PostNoteRequest request)
                 }
                 catch (Exception ex)
                 {
-                    logger.LogError(ex, "Failed to sync edit note to service {ServiceType}, note ID: {NoteId}", 
+                    logger.LogError(ex, "Failed to sync edit note to service {ServiceType}, note ID: {NoteId}",
                         syncNoteService.GetType().Name, newNote.Id);
                 }
             });
@@ -174,15 +174,15 @@ public async Task<PageData<Note>> GetUserNotes(long userId, int pageSize, int pa
         return await noteRepository.GetUserNotes(userId, pageSize, pageNumber, includePrivate);
     }
 
-    public async Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber)
+    public async Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber, long? excludeUserId = null)
     {
         if (pageNumber > Constants.PublicNotesMaxPage)
         {
             throw new Exception(
                 $"We only provide at most {Constants.PublicNotesMaxPage} page of public notes at the moment");
         }
 
-        var notes = await noteRepository.GetPublicNotes(pageSize, pageNumber);
+        var notes = await noteRepository.GetPublicNotes(pageSize, pageNumber, false, excludeUserId);
         if (notes.TotalCount > Constants.PublicNotesMaxPage * pageSize)
         {
             notes.TotalCount = Constants.PublicNotesMaxPage * pageSize;
@@ -328,7 +328,7 @@ public async Task<bool> Delete(long userId, long id)
                 }
                 catch (Exception ex)
                 {
-                    logger.LogError(ex, "Failed to sync delete note to service {ServiceType}, note ID: {NoteId}", 
+                    logger.LogError(ex, "Failed to sync delete note to service {ServiceType}, note ID: {NoteId}",
                         syncNoteService.GetType().Name, note.Id);
                 }
             });
@@ -377,7 +377,7 @@ public async Task<bool> Undelete(long userId, long id)
                     }
                     catch (Exception ex)
                     {
-                        logger.LogError(ex, "Failed to sync undelete note to service {ServiceType}, note ID: {NoteId}", 
+                        logger.LogError(ex, "Failed to sync undelete note to service {ServiceType}, note ID: {NoteId}",
                             syncNoteService.GetType().Name, undeletedNote.Id);
                     }
                 });

src/HappyNotes.Services/interfaces/INoteService.cs

@@ -16,11 +16,13 @@ public interface INoteService
     Task<PageData<Note>> GetUserNotes(long userId, int pageSize, int pageNumber, bool includePrivate = false);
     /// <summary>
     /// Latest public notes / random browsing
+    /// If excludeUserId is provided, notes from that user will be excluded (useful to avoid showing caller's own public notes).
     /// </summary>
     /// <param name="pageSize"></param>
     /// <param name="pageNumber"></param>
+    /// <param name="excludeUserId">Optional user id to exclude from results</param>
     /// <returns></returns>
-    Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber);
+    Task<PageData<Note>> GetPublicNotes(int pageSize, int pageNumber, long? excludeUserId = null);
 
     Task<PageData<Note>> GetUserTagNotes(long userId, int pageSize, int pageNumber, string tag);
     Task<PageData<Note>> GetUserKeywordNotes(long userId, int pageSize, int pageNumber, string keyword, NoteFilterType filter = NoteFilterType.Normal);

tests/HappyNotes.Common.Tests/StringExtensionsTests.cs

@@ -157,4 +157,24 @@ public void RemoveNoteLinksTest(string input, string expected)
         Assert.That(result, Is.EqualTo(expected));
     }
 
+
+    [TestCase(null, "")]
+    [TestCase("", "")]
+    [TestCase("Hello\nWorld", "Hello\nWorld")]  // Unix LF - unchanged
+    [TestCase("Hello\r\nWorld", "Hello\nWorld")]  // Windows CRLF → LF
+    [TestCase("Hello\rWorld", "Hello\nWorld")]  // Old Mac CR → LF
+    [TestCase("Hello\u2028World", "Hello\nWorld")]  // Unicode Line Separator → LF
+    [TestCase("Hello\u2029World", "Hello\n\nWorld")]  // Unicode Paragraph Separator → LF LF
+    [TestCase("Line1\r\nLine2\rLine3\nLine4", "Line1\nLine2\nLine3\nLine4")]  // Mixed formats
+    [TestCase("A\r\n\r\nB", "A\n\nB")]  // Multiple Windows line breaks
+    [TestCase("A\r\rB", "A\n\nB")]  // Multiple old Mac line breaks
+    [TestCase("Mixed\r\n\rformats\u2028here", "Mixed\n\nformats\nhere")]  // All types mixed
+    public void NormalizeNewlinesTest(string input, string expected)
+    {
+        // Act
+        var result = input.NormalizeNewlines();
+
+        // Assert
+        Assert.That(result, Is.EqualTo(expected));
+    }
 }

tests/HappyNotes.Services.Tests/NoteServiceTests.cs

@@ -298,7 +298,7 @@ public async Task GetPublicNotes_WithinMaxPage_ReturnsPageData()
             TotalCount = 1
         };
 
-        _mockNoteRepository.Setup(r => r.GetPublicNotes(pageSize, pageNumber, false))
+        _mockNoteRepository.Setup(r => r.GetPublicNotes(pageSize, pageNumber, false, It.IsAny<long?>()))
             .ReturnsAsync(expectedNotes);
 
         // Act