Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate EpochID encoding #269

Closed
ezdac opened this issue May 6, 2022 · 2 comments
Closed

Reevaluate EpochID encoding #269

ezdac opened this issue May 6, 2022 · 2 comments
Assignees

Comments

@ezdac
Copy link
Collaborator

ezdac commented May 6, 2022

Following up on #239 @jannikluhn and I had the discussion whether
the <uint32 block_number><uint32 batch index> coding of the EpochID is necessary.
We think that the EpochID can be any arbitrary number decided upon by the collator, as long as they stay unique (no reuse).
We did not see disadvantages to simply set the EpochID as the L2 BatchIndex, but thought this makes things easier.

Any objections? Why was the block number encoded in the epoch-id?

@ezdac ezdac added the T:rolling label May 6, 2022
@ezdac ezdac added this to the Rolling Shutter milestone May 6, 2022
@ezdac ezdac self-assigned this May 6, 2022
@ezdac
Copy link
Collaborator Author

ezdac commented May 9, 2022

#270 could be a reason to keep the combined encoding - but this only makes sense if the user signs the EpochID instead of BatchIndex and L1BlockNumber. Also we have the disadvantage of only 32 bit number-space each and probably would have to migrate to big integers.
I think this is not reason enough, since the combined encoding is not intuitive.

@ezdac ezdac removed their assignment May 9, 2022
@jannikluhn jannikluhn self-assigned this May 17, 2022
@jannikluhn
Copy link
Contributor

Done in 291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants