-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for fixup! commits #225
Comments
Agreed, |
workaround siderolabs/conform#225 Also people very commonly use WIP commits before tidying up, so allowing them is probably necessary if we want people not disabling conform pre-commit hook. Note that this does not affect CI that should ideally still fail on WIP commits (TODO: run conform on CI).
workaround siderolabs/conform#225 Also people very commonly use WIP commits before tidying up, so allowing them is probably necessary if we want people not disabling conform pre-commit hook. Note that this does not affect CI that should ideally still fail on WIP commits (TODO: run conform on CI).
workaround siderolabs/conform#225 Also people very commonly use WIP commits before tidying up, so allowing them is probably necessary if we want people not disabling conform pre-commit hook. Note that this does not affect CI that should ideally still fail on WIP commits (TODO: run conform on CI).
workaround siderolabs/conform#225 Also people very commonly use WIP commits before tidying up, so allowing them is probably necessary if we want people not disabling conform pre-commit hook. Note that this does not affect CI that should ideally still fail on WIP commits (TODO: run conform on CI).
@blaggacao I did'n try this, but I think this could be solved by a setting in the .conform.yaml, just adding allowed types:
|
That's a good idea, however we eneded up wrapping with a regex condition. That gives more flexibility to the actual header and thereby less restriction to the end use: divnix/std@2f047e0 |
Any way that works is the right way! :) Sidenote, I really like this tool, but would love to see more documentation, and more responses to the issues from the maintainer. |
The type |
When using conventional commits, allow the use of
fixup! <sha>
orfixup! <header>
syntax, which are both recognized bygit rebase --autosquash
later on.The text was updated successfully, but these errors were encountered: