Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a controller for handling machine request set which is created for managed control planes #705

Open
Tracked by #549
Unix4ever opened this issue Oct 24, 2024 · 0 comments · May be fixed by #723
Open
Tracked by #549

create a controller for handling machine request set which is created for managed control planes #705

Unix4ever opened this issue Oct 24, 2024 · 0 comments · May be fixed by #723
Assignees
@Unix4ever

Comments

@Unix4ever
Copy link
Member

Unix4ever commented Oct 24, 2024 •
edited
Loading

Implement the controller that will create machine request sets for the clusters which have managed control planes enabled.
Each cluster will have it's own machine request set with 3 requests.
Add omni.sidero.dev/managed label to the Cluster.

Open questions:

  • should we propagate the label to the MachineSet?
  • should the MachineSet be created by the controller?
@Unix4ever Unix4ever mentioned this issue Oct 24, 2024
Open
@Unix4ever Unix4ever self-assigned this Oct 24, 2024
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 4, 2024
@Unix4ever
feat: implement managed control planes
78c750f 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
@Unix4ever Unix4ever linked a pull request Nov 4, 2024 that will close this issue
Open
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 4, 2024
@Unix4ever
feat: implement managed control planes
af4d0dd 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 4, 2024
@Unix4ever
feat: implement managed control planes
67b7512 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 4, 2024
@Unix4ever
feat: implement managed control planes
3e5003c 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 4, 2024
@Unix4ever
feat: implement managed control planes
a7442d0 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 5, 2024
@Unix4ever
feat: implement managed control planes
073b3d9 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 5, 2024
@Unix4ever
feat: implement managed control planes
b300992 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 5, 2024
@Unix4ever
feat: implement managed control planes
ec410d1 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 5, 2024
@Unix4ever
feat: implement managed control planes
28b504d 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 12, 2024
@Unix4ever
feat: implement managed control planes
035c977 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 12, 2024
@Unix4ever
feat: implement managed control planes
8fb05e1 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 12, 2024
@Unix4ever
feat: implement managed control planes
e1234e4 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 12, 2024
@Unix4ever
feat: implement managed control planes
f4867d3 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever added a commit to Unix4ever/omni that referenced this issue Nov 13, 2024
@Unix4ever
feat: implement managed control planes
18095de 
Cluster template now has
```
managed:
  enable: true|false
```
configuration in the control planes model.
Creating managed control planes will be possible only if the Omni
account is configured with the provider to use for managed control
planes, otherwise resource validation won't allow creating the machine
set with such configuration.

Also drop `MachineRequestSet` allocation mode from the machine set,
remove source there, as it doesn't make much sense: for managed control
planes it should always use the machine request set name with the same
name as the machine set.

Config patches for managed mode are going to be added in the follow-up
PRs.

Fixes: siderolabs#705

Signed-off-by: Artem Chernyshev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Unix4ever Unix4ever

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement managed control planes Unix4ever/omni
1 participant
@Unix4ever