Make extensions discoverable by NFD #9070
SISheogorath
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
Yes, this sounds like a good idea, we can allow system extensions to publish a file under |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When nodes are configured differently, it can be hard to spot. E.g. if I have some nodes enabled with a different container runtime, like
gvisor
orkatacontainer
, it can be difficult to select these nodes.For enabling the discovery of CPU features and alike kubernetes has
node-feature-discovery
. node-feature-discovery has a local feature, which the talos extension mechanism could hook into: https://github.com/kubernetes-sigs/node-feature-discovery/blob/bd8d74d6f2523b5cc866801f4e6bdb1d113ffd5d/docs/usage/customization-guide.md#local-feature-sourceI first considered adding it to the extensions themselves but this will just be repeater over and over again. I have not found the right spot to implement it yet, but just providing the files in the mentioned directory, should enable any node-feature-discovery enabled cluster to select Talos extensions as node labels, while not causing any incompatibility with vanilla setups.
Beta Was this translation helpful? Give feedback.
All reactions