Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for unbuffered stdout #5

Open
Tarnasa opened this issue Jul 22, 2019 · 1 comment · May be fixed by #6
Open

Add support for unbuffered stdout #5

Tarnasa opened this issue Jul 22, 2019 · 1 comment · May be fixed by #6

Comments

@Tarnasa
Copy link

Tarnasa commented Jul 22, 2019

In Joueur.py, the "run" script forces python output to be unbuffered, this is so that when the client is running inside of Docker, its output can be seen immediately.

We should match this behavior in Joueur.lua.

I don't think lua supports a command-line flag to force this behavior, but instead requires a code change to the client.
@Tarnasa Tarnasa linked a pull request Jul 22, 2019 that will close this issue
Open
@JacobFischer
Copy link
Member

That's fair. IIRC it's all wrapped behind a logger anyways so it should be easy to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make stdout unbuffered Tarnasa/Joueur.lua
2 participants
@JacobFischer @Tarnasa