Call Link Restrictions not Updating Properly

[Sagar0-0]

Guidelines

• I have searched searched open and closed issues for duplicates
• I am submitting a bug report for existing functionality that does not work as intended
• This isn't a feature request or a discussion topic

Bug description

Steps to reproduce:

1. Create a new Call link
2. Join the call
3. Try to change the call settings(Change "Require admin approval Toggle button)

Problems:

1. This shows an invalid toast message showing, "Network issue"
   Solution: We should allow changing these settings during a call. Giving more flexibility to users. User should not have to end their call to change this setting. (Allow all pending approvals when the toggle button is off)
2. The Toggle button takes time to enable or disable when in the best scenario. We should show a progress bar when loading..
3. The toggle button changes can still show the same toast error for some time even when we are disconnected from the video call.
   Solution: This can be an issue from our internal CallManager class.

From the frontend side, I have added a loading state in the UpdateCallLinkResult, which works fine. Let me know if any more changes are expected from the front side. (I recommend adding a precise error toast)

The error code is 409.

Solving this in CallManager can also fix #13785. This issue is different as it focuses on the Toggle button state.

Screenshots

document_6312069446429054995.mp4

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

NA

[Sagar0-0]

Fixing the toggle button loading state properly also fixes the problem where the user can click on it multiple times leading to multiple triggered Jobs.

The 409 error status, indicates that the Link might be in use currently and we can show the same message when the user is trying to change the Restrictions settings. (This is already handled in the delete CallLink method)

[alex-signal]

Hi, this is partially fixed (async toggle indication / avoiding repeated clicks) in 7.29.0 and the toast label will be updated in 7.29.1