Skip to content

Commit b25d267

Browse files
author
shuning.chen
committed
Adding changes for linting fix
1 parent b8e4edd commit b25d267

File tree

7 files changed

+27
-27
lines changed

7 files changed

+27
-27
lines changed

instrumentation-genai/opentelemetry-instrumentation-langchain/examples/manual/langchain_single_agent.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import time
2+
13
from langchain.agents import create_agent
24

35

@@ -135,6 +137,5 @@ def get_weather(city: str) -> str:
135137
{"session_id": "12345"},
136138
)
137139

138-
# sleep for 150s to allow evals to finish
139-
import time
140+
# sleep for 150s to allow evals to finish
140141
time.sleep(150)

instrumentation-genai/opentelemetry-instrumentation-langchain/examples/manual/multi-agent.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
try: # pragma: no cover - optional dependency
2626
from opentelemetry.util.genai.handler import get_telemetry_handler
2727
except Exception: # pragma: no cover
28-
get_telemetry_handler = lambda **_: None # type: ignore
28+
def get_telemetry_handler(**_):
29+
return None # type: ignore
2930

3031
UTILS_PATH = Path(__file__).resolve().parent
3132
if __package__ in (None, ""):
@@ -66,7 +67,8 @@ def multi_agent_demo(llm: ChatOpenAI) -> None:
6667
try:
6768
from typing import Annotated, TypedDict
6869

69-
from langchain_core.messages import AIMessage, BaseMessage, HumanMessage, SystemMessage
70+
from langchain_core.messages import AIMessage, BaseMessage
71+
from langchain_core.runnables import RunnableLambda
7072
from langchain_core.tools import tool
7173
from langgraph.graph import END, StateGraph
7274
from langgraph.graph.message import add_messages

instrumentation-genai/opentelemetry-instrumentation-langchain/examples/manual/single-agent-codex.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
"""
1212

1313
import os
14-
import sys
15-
from pathlib import Path
1614
from typing import Any, Tuple
1715

1816
from .test_utils_splunk import DEFAULT_CACHE_FILE, create_cisco_chat_llm # type: ignore
@@ -60,7 +58,6 @@ def _simple_agent_demo_inner(llm: ChatOpenAI) -> None:
6058
try:
6159
from typing import Annotated, TypedDict
6260

63-
from langchain_core.messages import AIMessage
6461
from langchain_core.tools import tool
6562
from langgraph.graph import END, StateGraph
6663
from langgraph.graph.message import add_messages

instrumentation-genai/opentelemetry-instrumentation-langchain/examples/manual/single-agent.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
from pathlib import Path
44
from typing import Any, Tuple
55

6-
from langchain_core.messages import BaseMessage, HumanMessage, SystemMessage
7-
from langchain_core.runnables import RunnableLambda
6+
from langchain_core.messages import BaseMessage, HumanMessage
87
from langchain_openai import ChatOpenAI
98
from opentelemetry import _events, _logs, metrics, trace
109
from opentelemetry.exporter.otlp.proto.grpc._log_exporter import OTLPLogExporter
@@ -54,9 +53,7 @@ def _simple_agent_demo_inner(llm: ChatOpenAI) -> None:
5453
try:
5554
from typing import Annotated, TypedDict
5655

57-
from langchain_core.messages import AIMessage
5856
from langchain_core.tools import tool
59-
from langgraph.graph import END, StateGraph
6057
from langgraph.graph.message import add_messages
6158
from langgraph.prebuilt import create_react_agent
6259
except ImportError: # pragma: no cover - optional dependency

instrumentation-genai/opentelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/__init__.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@
2323
from wrapt import wrap_function_wrapper
2424
from opentelemetry.util.genai.handler import get_telemetry_handler
2525

26+
__all__ = [
27+
"LangchainInstrumentor",
28+
"get_event_logger",
29+
"__version__",
30+
"Meters",
31+
]
32+
2633
logger = logging.getLogger(__name__)
2734

2835
_instruments = ("langchain-core > 0.1.0", )
@@ -360,7 +367,7 @@ def __call__(
360367
args,
361368
kwargs,
362369
) -> None:
363-
run_manager = kwargs.get("run_manager")
370+
_run_manager = kwargs.get("run_manager") # noqa: F841
364371

365372
### FIXME: this was disabled to allow migration to util-genai and needs to be fixed
366373
# if run_manager:

instrumentation-genai/opentelemetry-instrumentation-langchain/tests/test_callback_handler_agent.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,22 @@
88
from uuid import uuid4
99

1010
import pytest
11-
try: # pragma: no cover - optional dependency in CI
12-
from langchain_core.messages import HumanMessage
13-
except ModuleNotFoundError: # pragma: no cover - allow running subset without langchain_core
14-
HumanMessage = None # type: ignore[assignment]
11+
12+
# Add package source to path if needed
1513
_PACKAGE_SRC = Path(__file__).resolve().parents[1] / "src"
1614
if _PACKAGE_SRC.exists():
1715
sys.path.insert(0, str(_PACKAGE_SRC))
1816

19-
from opentelemetry.sdk.trace import TracerProvider
17+
try: # pragma: no cover - optional dependency in CI
18+
from langchain_core.messages import HumanMessage
19+
except ModuleNotFoundError: # pragma: no cover - allow running subset without langchain_core
20+
HumanMessage = None # type: ignore[assignment]
2021

21-
from opentelemetry.instrumentation.langchain.callback_handler import (
22+
from opentelemetry.sdk.trace import TracerProvider # noqa: E402
23+
from opentelemetry.instrumentation.langchain.callback_handler import ( # noqa: E402
2224
LangchainCallbackHandler,
2325
)
24-
from opentelemetry.util.genai.types import Step, ToolCall
26+
from opentelemetry.util.genai.types import Step, ToolCall # noqa: E402
2527

2628
LANGCHAIN_CORE_AVAILABLE = HumanMessage is not None
2729

util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
import time
5454
from typing import Any, Optional
5555

56-
5756
try:
5857
from opentelemetry.util.genai.debug import genai_debug_log
5958
except Exception: # pragma: no cover - fallback if debug module missing
@@ -63,19 +62,14 @@ def genai_debug_log(*_args: Any, **_kwargs: Any) -> None: # type: ignore
6362

6463

6564
from opentelemetry import _events as _otel_events
66-
from opentelemetry import metrics as _metrics
6765
from opentelemetry import trace as _trace_mod
6866
from opentelemetry._logs import Logger, LoggerProvider, get_logger
6967
from opentelemetry.metrics import MeterProvider, get_meter
70-
from opentelemetry.semconv._incubating.attributes import (
71-
gen_ai_attributes as GenAI,
72-
)
7368
from opentelemetry.semconv.schemas import Schemas
7469
from opentelemetry.trace import (
7570
TracerProvider,
7671
get_tracer,
7772
)
78-
7973
from opentelemetry.util.genai.emitters.configuration import (
8074
build_emitter_pipeline,
8175
)
@@ -98,10 +92,10 @@ def genai_debug_log(*_args: Any, **_kwargs: Any) -> None: # type: ignore
9892
Workflow,
9993
)
10094
from opentelemetry.util.genai.utils import (
101-
get_content_capturing_mode,
10295
_is_truthy_env,
10396
_load_completion_callbacks,
104-
_parse_callback_filter
97+
_parse_callback_filter,
98+
get_content_capturing_mode,
10599
)
106100
from opentelemetry.util.genai.version import __version__
107101

0 commit comments

Comments
 (0)