Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page url to graphql #230

Closed
bitboxer opened this issue Feb 21, 2018 · 5 comments
Closed

Add page url to graphql #230

bitboxer opened this issue Feb 21, 2018 · 5 comments
Assignees

Comments

@bitboxer
Copy link
Member

I think it would be great to add the page url to the video and entry schemas of the graphql api. That way you could query using graphql and send the user to the correct page.

@bitboxer
Copy link
Member Author

Maybe @jann has an idea how to do this? Any hints welcome.

@bitboxer bitboxer added the API label Feb 21, 2018
@bitboxer
Copy link
Member Author

And while we are at it, we could also change the originalHref and copyright to always return something. If the source is SignDict, it should have an originalHref with the page link and the copyright should have the name of the user in it.

@jann jann self-assigned this Feb 23, 2018
@jann
Copy link
Member

jann commented Feb 23, 2018

#235 adds the url attribute to our entry model.
I have a few question regarding the rest.

  • For each video we already have the url stored in the database (video_url attribute)? or is this attribute meant for something else?
  • regarding originalHref and copyright: is the source is SignDict when the video was not previously imported, but recorded directly from the website?

@bitboxer
Copy link
Member Author

Oh, nice. Thanks!

The video_url is the raw mp4 file. I would love to have the possibility to link to the webpage that plays the video. For example this link: https://signdict.org/entry/835-zug/video/950

The copyright: if the original source is SignDict, the originalHref is empty, we should add our page as source for those videos. That way people who want to use our videos always can use the orignalHref without checking if it is empty or not.

@bitboxer
Copy link
Member Author

Closing this, the other missing things will be done in #771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants