-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sdr metric from MDX challenge #89
Comments
1️⃣ |
2️⃣ |
3️⃣ |
I got some feedback that this new metric is really just a SNR. Do you think SNR would be a good name ? Maybe TSNR for Track level SNR to emphasize the computation over the entire track no segments ? |
Hi Alexandre, actually only the |
4️⃣ |
5️⃣ |
actually lets do a vote on twitter: https://twitter.com/faroit/status/1620414432395558912?s=20 |
To me, this is simply SNR. Which can be gamed by rescaling the mixture... I'm actually worried that this is the right metric, tbh. |
@Jonathan-LeRoux but that is the same problem for the "real" SDR and we usually can't really do scale-invariance for music separation coming from the applications... 🤷♂️ We will have a perceptual part in the challenge this time but we need to drop SNR/SDR very soon, I agree. |
Following up on what I wrote on Twitter: I looked at the MDX paper and it doesn't look like the final metric uses any median averaging, it's all classical averages. In which case I think anybody reading "SNR" would imagine they'd compute the SNR of a whole song over the 2 channels then average that over songs, separately for each instrument (and average again to get the final metric). |
we want to add the simplified SDR metric from the MDX challenge, and we realized that
SDR
isn't clear. So we are willing to rename the simplified metric:Please vote:
The text was updated successfully, but these errors were encountered: