Fix encoding of artifacts with slashes in filename

Author: chrisvire

application/common/models/Build.php

@@ -499,7 +499,7 @@ public function getArtifactUrlBase() {
     }
 
     public function encodeFilename($filename) {
-        return rawurlencode($filename);
+        return str_replace('%2F', '/', rawurlencode($filename));
     }
 
     private function getArtifactUrl($pattern) {

application/tests/unit/common/components/BuildTest.php

@@ -96,5 +96,7 @@ public function testArtifactEncoding() {
         $build = Build::findOne(['id' => 12]);
         $apks = $build->apks();
         $this->assertContains("https://s3-us-west-2.amazonaws.com/sil-appbuilder-artifacts/testing/jobs/build_scriptureappbuilder_22/1/Test%2B1.0.apk", $apks, " *** filename not encoded correctly");
+        $playListing = $build->playListing();
+        $this->assertContains("https://s3-us-west-2.amazonaws.com/sil-appbuilder-artifacts/testing/jobs/build_scriptureappbuilder_22/1/play-listing/index.html", $playListing, " *** filename not encoded correctly");
     }
 }