code review changes

siltomato · RaymondLuong3 · commit bc47d273671c · 2025-10-27T10:25:14.000-06:00
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/app.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/app.component.ts
@@ -355,12 +355,12 @@ export class AppComponent extends DataLoadingComponent implements OnInit, OnDest
     if (this.currentUser == null) {
       return;
     } else if (!this.isAppOnline) {
-      void this.noticeService.show(this.i18n.translateStatic('app.action_not_available_offline'));
+      this.noticeService.show(this.i18n.translateStatic('app.action_not_available_offline'));
     } else {
       void this.authService
         .changePassword(this.currentUser.email)
         .then(() => {
-          void this.noticeService.show(this.i18n.translateStatic('app.password_reset_email_sent'));
+          this.noticeService.show(this.i18n.translateStatic('app.password_reset_email_sent'));
         })
         .catch(() => {
           void this.dialogService.message('app.cannot_change_password');
@@ -372,7 +372,7 @@ export class AppComponent extends DataLoadingComponent implements OnInit, OnDest
     if (this.isAppOnline) {
       void this.userService.editDisplayName(false);
     } else {
-      void this.noticeService.show(this.i18n.translateStatic('app.action_not_available_offline'));
+      this.noticeService.show(this.i18n.translateStatic('app.action_not_available_offline'));
     }
   }
 
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking-answers/checking-answers.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking-answers/checking-answers.component.ts
@@ -445,9 +445,9 @@ export class CheckingAnswersComponent implements OnInit {
         answer
       });
     } else if (likeAnswerResponse === LikeAnswerResponse.DeniedOwnAnswer) {
-      void this.noticeService.show(this.i18n.translateStatic('checking_answers.cannot_like_own_answer'));
+      this.noticeService.show(this.i18n.translateStatic('checking_answers.cannot_like_own_answer'));
     } else if (likeAnswerResponse === LikeAnswerResponse.DeniedNoPermission) {
-      void this.noticeService.show(this.i18n.translateStatic('checking_answers.no_permission_to_like'));
+      this.noticeService.show(this.i18n.translateStatic('checking_answers.no_permission_to_like'));
     }
   }
 
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts
@@ -858,7 +858,7 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A
         break;
       case 'delete':
         if (answerAction.answer != null) {
-          this.deleteAnswer(answerAction.answer);
+          void this.deleteAnswer(answerAction.answer);
         }
         break;
       case 'edit':
@@ -1278,7 +1278,7 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A
       : activeQuestionDoc.data.answers.findIndex(existingAnswer => existingAnswer.dataId === answer.dataId);
   }
 
-  private deleteAnswer(answer: Answer): void {
+  private async deleteAnswer(answer: Answer): Promise<void> {
     if (this.questionsList == null) {
       return;
     }
@@ -1288,7 +1288,7 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A
     }
     const answerIndex = this.getAnswerIndex(answer);
     if (answerIndex >= 0) {
-      void activeQuestionDoc
+      await activeQuestionDoc
         .submitJson0Op(op => {
           op.set(q => q.answers[answerIndex].deleted, true);
         })
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-dialog.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-dialog.component.ts
@@ -6,7 +6,7 @@ import { TranslocoService } from '@ngneat/transloco';
 import { Canon, VerseRef } from '@sillsdev/scripture';
 import { Question } from 'realtime-server/lib/esm/scriptureforge/models/question';
 import { fromVerseRef, toVerseRef } from 'realtime-server/lib/esm/scriptureforge/models/verse-ref-data';
-import { lastValueFrom, Subject } from 'rxjs';
+import { Subject } from 'rxjs';
 import { CsvService } from 'xforge-common/csv-service.service';
 import { DialogService } from 'xforge-common/dialog.service';
 import { ExternalUrlService } from 'xforge-common/external-url.service';
@@ -500,11 +500,13 @@ export class ImportQuestionsDialogComponent implements OnDestroy {
       ImportQuestionsConfirmationDialogComponent,
       data
     ) as MatDialogRef<ImportQuestionsConfirmationDialogComponent, ImportQuestionsConfirmationDialogResult>;
-    const result: ImportQuestionsConfirmationDialogResult | undefined = await lastValueFrom(dialogRef.afterClosed());
-    if (result != null) {
-      result.forEach((checked, index) => (changesToConfirm[index].checked = checked));
-    }
-    this.updateSelectAllCheckbox();
+
+    dialogRef.afterClosed().subscribe((result: ImportQuestionsConfirmationDialogResult | undefined) => {
+      if (result != null) {
+        result.forEach((checked, index) => (changesToConfirm[index].checked = checked));
+      }
+      this.updateSelectAllCheckbox();
+    });
   }
 
   private questionsDiffer(listItem: DialogListItem): boolean {
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/checking/question-dialog/question-dialog.service.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/checking/question-dialog/question-dialog.service.ts
@@ -44,7 +44,7 @@ export class QuestionDialogService {
       return questionDoc;
     }
     if (!(await this.canCreateAndEditQuestions(config.projectId))) {
-      void this.noticeService.show(this.transloco.translate('question_dialog.add_question_denied'));
+      this.noticeService.show(this.transloco.translate('question_dialog.add_question_denied'));
       return undefined;
     }
     const questionId = questionDoc != null && questionDoc.data != null ? questionDoc.data.dataId : objectId();
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/machine-api/remote-translation-engine.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/machine-api/remote-translation-engine.ts
@@ -97,15 +97,15 @@ export class RemoteTranslationEngine implements InteractiveTranslationEngine {
       return this.createWordGraph(response.data as WordGraphDto);
     } catch (err: any) {
       if (err.status === 403 || err.status === 404 || err.status === 409) {
-        void this.noticeService.showError(
+        this.noticeService.showError(
           this.i18n.translateStatic('error_messages.suggestion_engine_requires_retrain'),
           this.i18n.translateStatic('error_messages.go_to_retrain'),
           () => {
             void this.router.navigate(['projects', this.projectId, 'translate']);
           }
         );
       } else {
-        void this.noticeService.showError(this.i18n.translateStatic('error_messages.failed_to_retrieve_suggestions'));
+        this.noticeService.showError(this.i18n.translateStatic('error_messages.failed_to_retrieve_suggestions'));
       }
     }
 
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/my-projects/my-projects.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/my-projects/my-projects.component.ts
@@ -123,7 +123,7 @@ export class MyProjectsComponent implements OnInit {
       await this.projectService.onlineAddCurrentUser(projectId);
       void this.router.navigate(['projects', projectId]);
     } catch {
-      void this.noticeService.show(this.i18n.translateStatic('my_projects.failed_to_join_project'));
+      this.noticeService.show(this.i18n.translateStatic('my_projects.failed_to_join_project'));
     } finally {
       this.noticeService.loadingFinished(this.constructor.name);
       this.joiningProjects.pop();
@@ -134,11 +134,11 @@ export class MyProjectsComponent implements OnInit {
     try {
       this.noticeService.loadingStarted(this.constructor.name);
       await this.projectService.onlineSyncUserRole(projectId);
-      void this.noticeService.show(this.i18n.translateStatic('my_projects.user_role_updated'));
+      this.noticeService.show(this.i18n.translateStatic('my_projects.user_role_updated'));
       const project = this.userParatextProjects.find(project => project.projectId === projectId);
       if (project != null) project.hasUserRoleChanged = false;
     } catch {
-      void this.noticeService.showError(this.i18n.translateStatic('my_projects.failed_to_update_user_role'));
+      this.noticeService.showError(this.i18n.translateStatic('my_projects.failed_to_update_user_role'));
     } finally {
       this.noticeService.loadingFinished(this.constructor.name);
     }
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-project.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-project.component.ts
@@ -220,7 +220,7 @@ export class ServalProjectComponent extends DataLoadingComponent implements OnIn
           this.downloadBooksProgress = draftZipProgress.current;
           this.downloadBooksTotal = draftZipProgress.total;
         },
-        error: (error: Error) => void this.noticeService.showError(error.message)
+        error: (error: Error) => this.noticeService.showError(error.message)
       });
   }
 
@@ -244,7 +244,7 @@ export class ServalProjectComponent extends DataLoadingComponent implements OnIn
 
     // If the blob is undefined, display an error
     if (blob == null) {
-      void this.noticeService.showError('The project was never synced successfully and does not exist on disk.');
+      this.noticeService.showError('The project was never synced successfully and does not exist on disk.');
       return;
     }
 
@@ -260,7 +260,7 @@ export class ServalProjectComponent extends DataLoadingComponent implements OnIn
 
   async retrievePreTranslationStatus(): Promise<void> {
     await this.servalAdministrationService.onlineRetrievePreTranslationStatus(this.activatedProjectService.projectId!);
-    await this.noticeService.show('Webhook job started.');
+    this.noticeService.show('Webhook job started.');
   }
 
   navigateToDraftJobs(): void {
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/shared/audio-recorder-dialog/audio-recorder-dialog.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/shared/audio-recorder-dialog/audio-recorder-dialog.component.ts
@@ -232,9 +232,9 @@ export class AudioRecorderDialogComponent implements ControlValueAccessor, OnIni
     this.audio = { status: 'denied' };
 
     if (error.code === DOMException.NOT_FOUND_ERR) {
-      void this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_not_found'));
+      this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_not_found'));
     } else {
-      void this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_access_denied'));
+      this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_access_denied'));
     }
   }
 
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/shared/share/share-control.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/shared/share/share-control.component.ts
@@ -186,7 +186,7 @@ export class ShareControlComponent extends ShareBaseComponent {
       }
     }
 
-    void this.noticeService.show(message);
+    this.noticeService.show(message);
 
     const roleValue = this.shareRole;
     const localeValue = this.localeControl.value;
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/shared/share/share-dialog.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/shared/share/share-dialog.component.ts
@@ -168,7 +168,7 @@ export class ShareDialogComponent extends ShareBaseComponent {
       return;
     }
     void this.navigator.clipboard.writeText(this.shareableLink).then(async () => {
-      await this.noticeService.show(this.i18n.translateStatic('share_control.link_copied'));
+      this.noticeService.show(this.i18n.translateStatic('share_control.link_copied'));
       await this.reserveShareLink();
     });
   }
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/sync/sync.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/sync/sync.component.ts
@@ -108,7 +108,7 @@ export class SyncComponent extends DataLoadingComponent implements OnInit {
         )
       ) {
         if (this.projectDoc.data.sync.lastSyncSuccessful) {
-          void this.noticeService.show(
+          this.noticeService.show(
             this.i18n.translateStatic('sync.successfully_synchronized_with_paratext', { projectName })
           );
           this.previousLastSyncDate = this.lastSyncDate;
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-download-button/draft-download-button.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-download-button/draft-download-button.component.ts
@@ -49,7 +49,7 @@ export class DraftDownloadButtonComponent {
           this.downloadBooksProgress = draftZipProgress.current;
           this.downloadBooksTotal = draftZipProgress.total;
         },
-        error: (error: Error) => void this.noticeService.showError(error.message)
+        error: (error: Error) => this.noticeService.showError(error.message)
       });
   }
 }
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts
@@ -544,7 +544,7 @@ export class DraftGenerationStepsComponent implements OnInit {
       this.stepper.next();
     } else {
       if (!this.onlineStatusService.isOnline) {
-        void this.noticeService.show(this.i18n.translateStatic('draft_generation.offline_message'));
+        this.noticeService.show(this.i18n.translateStatic('draft_generation.offline_message'));
         return;
       }
 
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.service.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.service.ts
@@ -75,7 +75,7 @@ export class DraftGenerationService {
           return of(undefined);
         }
 
-        void this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
+        this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
         return of(undefined);
       })
     );
@@ -99,7 +99,7 @@ export class DraftGenerationService {
           return of(undefined);
         }
 
-        void this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
+        this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
         return of(undefined);
       })
     );
@@ -125,7 +125,7 @@ export class DraftGenerationService {
             return of(undefined);
           }
 
-          void this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
+          this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
           return of(undefined);
         })
       );
@@ -202,7 +202,7 @@ export class DraftGenerationService {
             return of({});
           }
 
-          void this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
+          this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
           return of({});
         })
       );
@@ -250,7 +250,7 @@ export class DraftGenerationService {
           return throwError(() => err);
         }
 
-        void this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
+        this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
         return of([]);
       })
     );
@@ -279,7 +279,7 @@ export class DraftGenerationService {
             return of(undefined);
           }
 
-          void this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
+          this.noticeService.showError(this.i18n.translateStatic('draft_generation.temporarily_unavailable'));
           return of(undefined);
         })
       );
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-usfm-format/draft-usfm-format.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-usfm-format/draft-usfm-format.component.ts
@@ -218,7 +218,7 @@ export class DraftUsfmFormatComponent extends DataLoadingComponent implements Af
       this.close();
     } catch (err) {
       console.error('Error occurred while saving draft format', err);
-      void this.noticeService.showError(this.i18n.translateStatic('draft_usfm_format.failed_to_save'));
+      this.noticeService.showError(this.i18n.translateStatic('draft_usfm_format.failed_to_save'));
     } finally {
       this.saving = false;
     }
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.ts
@@ -295,7 +295,7 @@ export class EditorDraftComponent implements AfterViewInit, OnChanges {
       this.isDraftApplied = true;
       this.userAppliedDraft = true;
     } catch (err) {
-      void this.noticeService.showError(this.i18n.translateStatic('editor_draft_tab.error_applying_draft'));
+      this.noticeService.showError(this.i18n.translateStatic('editor_draft_tab.error_applying_draft'));
       if (!isNetworkError(err)) {
         this.errorReportingService.silentError(
           'Error applying a draft to a chapter',
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-history/history-chooser/history-chooser.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-history/history-chooser/history-chooser.component.ts
@@ -142,7 +142,7 @@ export class HistoryChooserComponent implements AfterViewInit, OnChanges {
 
   async revertToSnapshot(): Promise<void> {
     if (!this.onlineStatusService.isOnline) {
-      void this.noticeService.show(this.i18n.translateStatic('history_chooser.please_connect'));
+      this.noticeService.show(this.i18n.translateStatic('history_chooser.please_connect'));
       return;
     }
     // Ensure the user wants to proceed
@@ -162,7 +162,7 @@ export class HistoryChooserComponent implements AfterViewInit, OnChanges {
       this.chapter == null ||
       !this.canRestoreSnapshot
     ) {
-      void this.noticeService.showError(this.i18n.translateStatic('history_chooser.error'));
+      this.noticeService.showError(this.i18n.translateStatic('history_chooser.error'));
       return;
     }
 
@@ -183,11 +183,11 @@ export class HistoryChooserComponent implements AfterViewInit, OnChanges {
       }
       await this.textDocService.overwrite(textDocId, delta, 'History');
 
-      void this.noticeService.show(this.i18n.translateStatic('history_chooser.revert_successful'));
+      this.noticeService.show(this.i18n.translateStatic('history_chooser.revert_successful'));
       // Force the history editor to reload
       this.revisionSelect.emit({ revision: this.selectedRevision, snapshot: this.selectedSnapshot });
     } catch (err) {
-      void this.noticeService.showError(this.i18n.translateStatic('history_chooser.revert_error'));
+      this.noticeService.showError(this.i18n.translateStatic('history_chooser.revert_error'));
       if (!isNetworkError(err)) {
         this.errorReportingService.silentError(
           'Error occurred restoring a snapshot',
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts
@@ -1195,7 +1195,7 @@ export class EditorComponent extends DataLoadingComponent implements OnDestroy,
       return;
     }
     if (!this.target.contentShowing) {
-      void this.noticeService.show(this.i18n.translateStatic('editor.navigate_to_a_valid_text'));
+      this.noticeService.show(this.i18n.translateStatic('editor.navigate_to_a_valid_text'));
       return;
     }
     let verseRef: VerseRef | undefined = this.commenterSelectedVerseRef;
@@ -1817,7 +1817,7 @@ export class EditorComponent extends DataLoadingComponent implements OnDestroy,
     } else if (!translator.isSegmentValid) {
       this.translator = undefined;
       if (this.translationSuggestionsEnabled) {
-        void this.noticeService.show(this.i18n.translateStatic('editor.verse_too_long_for_suggestions'));
+        this.noticeService.show(this.i18n.translateStatic('editor.verse_too_long_for_suggestions'));
       }
       return;
     }
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/training-progress/training-progress.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/training-progress/training-progress.component.ts
@@ -141,9 +141,7 @@ export class TrainingProgressComponent extends DataLoadingComponent implements O
           complete: () => {
             // training completed successfully
             if (this.trainingProgressClosed) {
-              void this.noticeService.show(
-                this.i18n.translateStatic('training_progress.training_completed_successfully')
-              );
+              this.noticeService.show(this.i18n.translateStatic('training_progress.training_completed_successfully'));
               this.trainingProgressClosed = false;
             } else {
               this.trainingMessage = this.i18n.translateStatic('training_progress.completed_successfully');
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/translate-overview/translate-overview.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/translate-overview/translate-overview.component.ts
@@ -159,7 +159,7 @@ export class TranslateOverviewComponent extends DataLoadingComponent implements
         if (error instanceof HttpErrorResponse && error.status === 401) {
           void this.authService.requestParatextCredentialUpdate();
         } else {
-          void this.noticeService.showError(this.i18n.translateStatic('translate_overview.training_unavailable'));
+          this.noticeService.showError(this.i18n.translateStatic('translate_overview.training_unavailable'));
         }
       })
       .then(() => void this.listenForStatus());
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/users/collaborators/collaborators.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/users/collaborators/collaborators.component.ts
@@ -264,7 +264,7 @@ export class CollaboratorsComponent extends DataLoadingComponent implements OnIn
       );
       this._userRows = userRows.concat(invitees);
     } catch {
-      void this.noticeService.show(this.i18n.translateStatic('collaborators.problem_loading_invited_users'));
+      this.noticeService.show(this.i18n.translateStatic('collaborators.problem_loading_invited_users'));
     }
   }
 }
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/auth-http-interceptor.ts b/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/auth-http-interceptor.ts
@@ -42,7 +42,7 @@ export class AuthHttpInterceptor implements HttpInterceptor {
       // JSON RPC responds with this status code for 401 unauthorized
       case CommandErrorCode.InvalidRequest:
       case 401:
-        await this.authService!.expireToken();
+        this.authService!.expireToken();
         return await this.handle(req, next);
     }
     // HTTP/2 Requests do not carry the status text from the HTTP/1.1 Request
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/auth.service.ts b/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/auth.service.ts
@@ -213,7 +213,7 @@ export class AuthService {
     }
   }
 
-  async expireToken(): Promise<void> {
+  expireToken(): void {
     this.localSettings.set(EXPIRES_AT_SETTING, 0);
   }
 
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/exception-handling.service.ts b/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/exception-handling.service.ts
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/notice.service.ts b/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/notice.service.ts
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/user.service.ts b/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/user.service.ts

Original file line number	Diff line number	Diff line change
`@@ -445,9 +445,9 @@ export class CheckingAnswersComponent implements OnInit {`
`445`	`445`	`answer`
`446`	`446`	`});`
`447`	`447`	`} else if (likeAnswerResponse === LikeAnswerResponse.DeniedOwnAnswer) {`
`448`		`- void this.noticeService.show(this.i18n.translateStatic('checking_answers.cannot_like_own_answer'));`
	`448`	`+ this.noticeService.show(this.i18n.translateStatic('checking_answers.cannot_like_own_answer'));`
`449`	`449`	`} else if (likeAnswerResponse === LikeAnswerResponse.DeniedNoPermission) {`
`450`		`- void this.noticeService.show(this.i18n.translateStatic('checking_answers.no_permission_to_like'));`
	`450`	`+ this.noticeService.show(this.i18n.translateStatic('checking_answers.no_permission_to_like'));`
`451`	`451`	`}`
`452`	`452`	`}`
`453`	`453`
Original file line number	Diff line number	Diff line change
`@@ -858,7 +858,7 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A`
`858`	`858`	`break;`
`859`	`859`	`case 'delete':`
`860`	`860`	`if (answerAction.answer != null) {`
`861`		`- this.deleteAnswer(answerAction.answer);`
	`861`	`+ void this.deleteAnswer(answerAction.answer);`
`862`	`862`	`}`
`863`	`863`	`break;`
`864`	`864`	`case 'edit':`
`@@ -1278,7 +1278,7 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A`
`1278`	`1278`	`: activeQuestionDoc.data.answers.findIndex(existingAnswer => existingAnswer.dataId === answer.dataId);`
`1279`	`1279`	`}`
`1280`	`1280`
`1281`		`- private deleteAnswer(answer: Answer): void {`
	`1281`	`+ private async deleteAnswer(answer: Answer): Promise<void> {`
`1282`	`1282`	`if (this.questionsList == null) {`
`1283`	`1283`	`return;`
`1284`	`1284`	`}`
`@@ -1288,7 +1288,7 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A`
`1288`	`1288`	`}`
`1289`	`1289`	`const answerIndex = this.getAnswerIndex(answer);`
`1290`	`1290`	`if (answerIndex >= 0) {`
`1291`		`- void activeQuestionDoc`
	`1291`	`+ await activeQuestionDoc`
`1292`	`1292`	`.submitJson0Op(op => {`
`1293`	`1293`	`op.set(q => q.answers[answerIndex].deleted, true);`
`1294`	`1294`	`})`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export class QuestionDialogService {`
`44`	`44`	`return questionDoc;`
`45`	`45`	`}`
`46`	`46`	`if (!(await this.canCreateAndEditQuestions(config.projectId))) {`
`47`		`- void this.noticeService.show(this.transloco.translate('question_dialog.add_question_denied'));`
	`47`	`+ this.noticeService.show(this.transloco.translate('question_dialog.add_question_denied'));`
`48`	`48`	`return undefined;`
`49`	`49`	`}`
`50`	`50`	`const questionId = questionDoc != null && questionDoc.data != null ? questionDoc.data.dataId : objectId();`
Original file line number	Diff line number	Diff line change
`@@ -97,15 +97,15 @@ export class RemoteTranslationEngine implements InteractiveTranslationEngine {`
`97`	`97`	`return this.createWordGraph(response.data as WordGraphDto);`
`98`	`98`	`} catch (err: any) {`
`99`	`99`	`if (err.status === 403 \|\| err.status === 404 \|\| err.status === 409) {`
`100`		`- void this.noticeService.showError(`
	`100`	`+ this.noticeService.showError(`
`101`	`101`	`this.i18n.translateStatic('error_messages.suggestion_engine_requires_retrain'),`
`102`	`102`	`this.i18n.translateStatic('error_messages.go_to_retrain'),`
`103`	`103`	`() => {`
`104`	`104`	`void this.router.navigate(['projects', this.projectId, 'translate']);`
`105`	`105`	`}`
`106`	`106`	`);`
`107`	`107`	`} else {`
`108`		`- void this.noticeService.showError(this.i18n.translateStatic('error_messages.failed_to_retrieve_suggestions'));`
	`108`	`+ this.noticeService.showError(this.i18n.translateStatic('error_messages.failed_to_retrieve_suggestions'));`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
Original file line number	Diff line number	Diff line change
`@@ -232,9 +232,9 @@ export class AudioRecorderDialogComponent implements ControlValueAccessor, OnIni`
`232`	`232`	`this.audio = { status: 'denied' };`
`233`	`233`
`234`	`234`	`if (error.code === DOMException.NOT_FOUND_ERR) {`
`235`		`- void this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_not_found'));`
	`235`	`+ this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_not_found'));`
`236`	`236`	`} else {`
`237`		`- void this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_access_denied'));`
	`237`	`+ this.noticeService.show(this.i18n.translateStatic('checking_audio_recorder.mic_access_denied'));`
`238`	`238`	`}`
`239`	`239`	`}`
`240`	`240`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ export class ShareControlComponent extends ShareBaseComponent {`
`186`	`186`	`}`
`187`	`187`	`}`
`188`	`188`
`189`		`- void this.noticeService.show(message);`
	`189`	`+ this.noticeService.show(message);`
`190`	`190`
`191`	`191`	`const roleValue = this.shareRole;`
`192`	`192`	`const localeValue = this.localeControl.value;`