Rename "Details" button to "Edit Details"

[purplespider]

Initially reported in original PR: #1038

New in Silverstripe 4.6 is the ability to edit file information directly in the modal.

When adjusting an image in an UploadField, the Details fields are read-only, and the button to make them editable is confusing just labelled "Details":

A primary use case of this button is when using the FocusPoint module.

---

The same button exists in a different context when editing a WYSIWYG image:

Here, the Details fields are not visible, so changing it to just say "Edit" would be unclear.

---

Therefore I suggest renaming it to say Edit Details so that the action is clear in both contexts.

[purplespider]

I should mention, that the ideal here is that when adjusting an UploadField image, the details fields are immediately editable, rather than read-only. Then we don't even need to display a button.

[lerni]

To me click on a button to edit settings that belongs to a file makes sense and therefor just have fields like placement etc. editable is well OK. But "Details" doesn't make clear that you probable edit something that is used elsewhere. I agree "Edit Details" or even "Edit File Settings" would explain that better than just "Details".

[micschk]

The '(Edit) Details' button isn't shown at all when this same modal gets loaded from an UploadField.
Only a cross is shown, without any label or title or any clue ("Cancel" aria-label, actually unlinks the current image oh wait, it doesn't, even more confusing if you ask me).
Stunning UI 'improvements', all this used to work way more intuitive in a certain earlier versions...

[lerni]

I've tried to reproduce what @micschk wrote with 4.8.x and 4.9.0-rc1 but either I do not understand or I cannot.

This button?

I wonder with what versions or other "Environment variables" like language etc. you used, to get that result?

4.8.x

silverstripe/framework (4.8.0)
silverstripe/admin (1.8.0) 
silverstripe/cms (4.8.0)
silverstripe/assets (1.8.0)

4.9.0-rc1

silverstripe/framework (4.9.0-rc1)
silverstripe/admin (1.9.0-rc1)
silverstripe/cms (4.9.0-rc1)
silverstripe/assets (1.9.0-rc1)

[purplespider]

@micschk Maybe you are experiencing this bug?: "(Edit) Details" button only visible if grid shows the page of selected file #1136

[micschk]

@micschk Maybe you are experiencing this bug?: "(Edit) Details" button only visible if grid shows the page of selected file #1136

Aah, yes that appears to be it! And the issue thread even contains a composer command to pull the fix in... Thanks!

[clarkepaul]

I've left a bit more thoughts on issue #1209, for example not having much space near the file title due to long file names and another idea of having the link in the actions bar at the bottom.

Works a bit better for the Uploadfield experience too as a potential quick fix.
Doesn't resolve the double click to edit for the upload field though, more on that in #1209 as well.

[nathanbrauer]

Going back to the original ask of this issue: Rename "Details" to "Edit Details"....

I would argue that this is deserving of a higher impact label seeing as I just spent an hour trying to find a way to enable editing on via UploadField only to finally find these tickets find that "[Icon] Details" actually meant "Edit Details". I'm sure I'm not the only one.

Given how incredibly simple this change should be, do we think we can get this updated soon?

PS: Hi, it's been a while but I'm back :)

[GuySartorelli]

Closing as a duplicate of #1209 since there's more discussion in that issue.