Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit f810c8a

Browse files
author
Kent C. Dodds
committedJul 8, 2019
feat: initial release of scoped package
Reference: testing-library/dom-testing-library#260 BREAKING CHANGE: You need to uninstall `jest-dom` and install `@testing-library/jest-dom` instead. Then change your imports from `jest-dom` to `@testing-library/jest-dom`.
1 parent 0d04699 commit f810c8a

13 files changed

+255
-193
lines changed
 

‎.github/ISSUE_TEMPLATE.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ never done that before, that's great! Check this free short video tutorial to
1111
learn how: http://kcd.im/pull-request
1212
-->
1313

14-
* `jest-dom` version:
15-
* `node` version:
16-
* `npm` (or `yarn`) version:
14+
- `@testing-library/jest-dom` version:
15+
- `node` version:
16+
- `npm` (or `yarn`) version:
1717

1818
Relevant code or config
1919

‎.github/ISSUE_TEMPLATE/Bug_Report.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ tutorial to learn how: http://kcd.im/pull-request
1818
1919
-->
2020

21-
* `jest-dom` version:
22-
* `node` version:
23-
* `npm` (or `yarn`) version:
21+
- `@testing-library/jest-dom` version:
22+
- `node` version:
23+
- `npm` (or `yarn`) version:
2424

2525
<!--
2626
* `dom-testing-library` version: (if applicable)

‎.github/ISSUE_TEMPLATE/Question.md

+3-6
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,8 @@ and feature requests so we recommend not using this medium to ask them here 😁
1212

1313
## ❓ Support Forums
1414

15-
* React Spectrum
16-
https://spectrum.chat/react-testing-library
17-
* Reactiflux on Discord
18-
https://www.reactiflux.com
19-
* Stack Overflow
20-
https://stackoverflow.com/questions/tagged/jest-dom
15+
- React Spectrum https://spectrum.chat/react-testing-library
16+
- Reactiflux on Discord https://www.reactiflux.com
17+
- Stack Overflow https://stackoverflow.com/questions/tagged/jest-dom
2118

2219
**ISSUES WHICH ARE QUESTIONS WILL BE CLOSED**

‎.github/PULL_REQUEST_TEMPLATE.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -14,30 +14,30 @@ Please fill out the information below to expedite the review and (hopefully)
1414
merge of your pull request!
1515
-->
1616

17-
1817
**What**:
19-
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
2018

19+
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
2120

2221
**Why**:
23-
<!-- Why are these changes necessary? -->
2422

23+
<!-- Why are these changes necessary? -->
2524

2625
**How**:
27-
<!-- How were these changes implemented? -->
2826

27+
<!-- How were these changes implemented? -->
2928

3029
**Checklist**:
30+
3131
<!-- Have you done all of these things? -->
3232

3333
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
3434

3535
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
3636

37-
* [ ] Documentation
38-
* [ ] Tests
39-
* [ ] Updated Type Definitions
40-
* [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
41-
* [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->
37+
- [ ] Documentation
38+
- [ ] Tests
39+
- [ ] Updated Type Definitions
40+
- [ ] Ready to be merged
41+
<!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
4242

4343
<!-- feel free to add additional comments -->

‎.prettierrc

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@
66
"singleQuote": true,
77
"trailingComma": "all",
88
"bracketSpacing": false,
9-
"jsxBracketSameLine": false
9+
"jsxBracketSameLine": false,
10+
"proseWrap": "always"
1011
}

‎CHANGELOG.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# CHANGELOG
22

3-
The changelog is automatically updated using [semantic-release](https://github.com/semantic-release/semantic-release).
4-
You can see it on the [releases page](../../releases).
3+
The changelog is automatically updated using
4+
[semantic-release](https://github.com/semantic-release/semantic-release). You
5+
can see it on the [releases page](../../releases).

‎CONTRIBUTING.md

+11-38
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
Thanks for being willing to contribute!
44

5-
**Working on your first Pull Request?** You can learn how from this _free_ series
6-
[How to Contribute to an Open Source Project on GitHub][egghead]
5+
**Working on your first Pull Request?** You can learn how from this _free_
6+
series [How to Contribute to an Open Source Project on GitHub][egghead]
77

88
## Project setup
99

@@ -20,45 +20,17 @@ Thanks for being willing to contribute!
2020
> git branch --set-upstream-to=upstream/master master
2121
> ```
2222
>
23-
> This will add the original repository as a "remote" called "upstream,"
24-
> Then fetch the git information from that remote, then set your local `master`
25-
> branch to use the upstream master branch whenever you run `git pull`.
26-
> Then you can make all of your pull request branches based on this `master`
27-
> branch. Whenever you want to update your version of `master`, do a regular
28-
> `git pull`.
29-
30-
## Add yourself as a contributor
31-
32-
This project follows the [all contributors][all-contributors] specification.
33-
To add yourself to the table of contributors on the `README.md`, please use the
34-
automated script as part of your PR:
35-
36-
```console
37-
npm run add-contributor
38-
```
39-
40-
Follow the prompt and commit `.all-contributorsrc` and `README.md` in the PR.
41-
If you've already added yourself to the list and are making
42-
a new type of contribution, you can run it again and select the added
43-
contribution type.
23+
> This will add the original repository as a "remote" called "upstream," Then
24+
> fetch the git information from that remote, then set your local `master`
25+
> branch to use the upstream master branch whenever you run `git pull`. Then you
26+
> can make all of your pull request branches based on this `master` branch.
27+
> Whenever you want to update your version of `master`, do a regular `git pull`.
4428
4529
## Committing and Pushing changes
4630
4731
Please make sure to run the tests before you commit your changes. You can run
48-
`npm run test:update` which will update any snapshots that need updating.
49-
Make sure to include those changes (if they exist) in your commit.
50-
51-
### opt into git hooks
52-
53-
There are git hooks set up with this project that are automatically installed
54-
when you install dependencies. They're really handy, but are turned off by
55-
default (so as to not hinder new contributors). You can opt into these by
56-
creating a file called `.opt-in` at the root of the project and putting this
57-
inside:
58-
59-
```
60-
pre-commit
61-
```
32+
`npm run test:update` which will update any snapshots that need updating. Make
33+
sure to include those changes (if they exist) in your commit.
6234
6335
## Help needed
6436
@@ -67,6 +39,7 @@ Please checkout the [the open issues][issues]
6739
Also, please watch the repo and respond to questions/bug reports/feature
6840
requests! Thanks!
6941
70-
[egghead]: https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
42+
[egghead]:
43+
https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
7144
[all-contributors]: https://github.com/all-contributors/all-contributors
7245
[issues]: https://github.com/testing-library/jest-dom/issues

0 commit comments

Comments
 (0)
Please sign in to comment.