Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow canceling select-to-zoom interaction with right click #1463

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jul 26, 2023

Fix #1370 -- this is quite a neat interaction, actually.

Couple of notes:

  • Pressing the context menu key on the keyboard also cancels the interaction.
  • Firefox does not fire the contextmenu event at all when Shift is pressed. So with the proposed solution, a select-to-zoom interaction configured with the Shift modifier key cannot be cancelled with right click.

Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, indeed 👍

@axelboc axelboc merged commit d912a67 into main Aug 8, 2023
8 checks passed
@axelboc axelboc deleted the cancel-zoom-right-click branch August 8, 2023 08:01
@axelboc
Copy link
Contributor Author

axelboc commented Aug 11, 2023

Bug fix: 5da1e6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel ZoomMode interaction with right mouse button click
2 participants