Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login POST target ignores base_url #25

Closed
meowcat opened this issue Aug 17, 2023 · 0 comments
Closed

Login POST target ignores base_url #25

meowcat opened this issue Aug 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@meowcat
Copy link

meowcat commented Aug 17, 2023

datasette-auth-passwords/datasette_auth_passwords/templates/password_login.html

Line 31 in 3d60f37

<form class="password-login" action="/-/login" method="post">

This leads to a wrong url target if base_url is set.
meowcat pushed a commit to meowcat/datasette-auth-passwords that referenced this issue Aug 17, 2023
Fixed POST target and redirection URL, fixing simonw#25
e345e12
simonw added a commit that referenced this issue Sep 3, 2024
@simonw
Merge pull request #26 from meowcat/main
0229873 
Fixed POST target and redirection URL, fixing #25
@simonw simonw closed this as completed Sep 3, 2024
@simonw simonw added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonw @meowcat