-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get JSR @datasette/table to work #89
Comments
I wonder if you're needing to manually add dependencies of your dependencies to your project? That seems weird though, but might work |
Got some help on JSR Discord, it turns out this may actually be a bug! Bill Mill figured out a workaround using Deno and a plugin: https://notes.billmill.org/programming/javascript/build_tools/using_esbuild_to_package_a_deno_package_for_the_browser.html |
Looks like JSR is adding the I assume this is to make your package compatible with Deno, which uses that specifier for Node compatibility: https://docs.deno.com/runtime/manual/node/npm_specifiers My gut feeling tells me this is a JSR bug/edge case because I don't see this documented anywhere. But since you're publishing JavaScript, the "source" and the "dist" is the same file, and so JSR tries to make it compatible with Deno by adding the My gut feeling could be wrong though. EDIT: Oh wow, while researching and writing this it turns out you reached the same conclusion. 😅 |
As shown in this TIL, I got stuck! https://til.simonwillison.net/javascript/jsr-esbuild
Error:
I want to run my https://jsr.io/@datasette/table component in a browser, installed via JSR.
Here's what it looks like when it works: https://simonw.github.io/datasette-table/
Code here: https://github.com/simonw/datasette-table/
The text was updated successfully, but these errors were encountered: