Replies: 1 comment
-
Gosh - you're right. I somewhat never took care of cleaning them up. Fixed in 6b02489, I'll release a new patch version this weekend :) Thank you for raising this issue! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I ran into an issue on a VueJS app that had listeners defined using
on()
but used anonymous functions. When the view was swapped out and back into the page (using vue router), the listeners were added a second time.I saw an example Vue project that used destroy, but didnt mention cleaning up events. I solved it on my side by specifically defining the functions in my component and using
off()
and each one in the component'sbeforeDestroy()
call. But if there isn't any good reason/example to keep these events attached after a call todestroy()
, can we have SelectionJS handle this for us? When I seedestroy()
and its description, I assume that events are also destroyed.Beta Was this translation helpful? Give feedback.
All reactions