Remove legacy facts

[nick-markowski]

java_max_memory, max_active_instances, reserved_code_cache use memorysize_mb which is not a fact in Puppet 8. There could be others, if you don't mind running through the module to double check for legacy facts.

[nick-markowski]

Found the following legacy facts (so far)

• https://github.com/simp/pupmod-simp-pupmod/blob/master/functions/java_max_memory.pp#L13
• https://github.com/simp/pupmod-simp-pupmod/blob/master/functions/max_active_instances.pp#L26
• https://github.com/simp/pupmod-simp-pupmod/blob/master/functions/reserved_code_cache.pp#L8
• https://github.com/simp/pupmod-simp-pupmod/blob/master/templates/etc/puppetserver/conf.d/webserver.conf.epp#L14-L15
• https://github.com/simp/pupmod-simp-pupmod/blob/master/templates/etc/puppetserver/conf.d/webserver.conf.epp#L39-L40
• https://github.com/simp/pupmod-simp-pupmod/blob/master/templates/etc/sysconfig/puppetserver.epp#L4
• https://github.com/simp/pupmod-simp-pupmod/blob/master/templates/usr/local/sbin/puppetserver_clear_environment_cache.epp#L13