Skip to content

Commit f20373c

Browse files
authored
Do not create an "invalid" key when Org elements are empty. (#325)
This has been present since the initial commit. However it seems nothing handles 'invalid' keys after that or does anything with it. It's unclear what the meaning was or at least is. It does produce these keys in parsing metadata in SimpleSAML without (some) org elements.
1 parent 13ce4ab commit f20373c

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/SAML2/XML/md/Organization.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,23 +63,14 @@ public function __construct(DOMElement $xml = null)
6363
$this->Extensions = Extensions::getList($xml);
6464

6565
$this->OrganizationName = Utils::extractLocalizedStrings($xml, Constants::NS_MD, 'OrganizationName');
66-
if (empty($this->OrganizationName)) {
67-
$this->OrganizationName = ['invalid' => ''];
68-
}
6966

7067
$this->OrganizationDisplayName = Utils::extractLocalizedStrings(
7168
$xml,
7269
Constants::NS_MD,
7370
'OrganizationDisplayName'
7471
);
75-
if (empty($this->OrganizationDisplayName)) {
76-
$this->OrganizationDisplayName = ['invalid' => ''];
77-
}
7872

7973
$this->OrganizationURL = Utils::extractLocalizedStrings($xml, Constants::NS_MD, 'OrganizationURL');
80-
if (empty($this->OrganizationURL)) {
81-
$this->OrganizationURL = ['invalid' => ''];
82-
}
8374
}
8475

8576

0 commit comments

Comments
 (0)