Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link with hash in contents is marked as double-link #194

Open
ByteSnipers opened this issue Jun 3, 2024 · 1 comment
Open

Direct link with hash in contents is marked as double-link #194

ByteSnipers opened this issue Jun 3, 2024 · 1 comment

Comments

@ByteSnipers
Copy link

How to reproduce.
Affected repo: https://github.com/ByteSnipers/awesome-pentest-cheat-sheets

  1. run
    npx awesome-lint https://github.com/ByteSnipers/awesome-pentest-cheat-sheets

output:
✖ 9:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#-security-talks-and-videos remark-lint:double-link
✖ 11:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#-mobile-pentesting remark-lint:double-link
✖ 12:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#%EF%B8%8F-cloud-pentesting remark-lint:double-link
✖ 13:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#active-directory remark-lint:double-link
✖ 14:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#-pentest-methodology remark-lint:double-link
✖ 15:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#-privilege-escalation remark-lint:double-link
✖ 16:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#%EF%B8%8F-web-pentesting remark-lint:double-link
✖ 17:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#binary-exploitation remark-lint:double-link
✖ 18:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#learning-platforms remark-lint:double-link
✖ 19:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#bug-bounty remark-lint:double-link
✖ 20:3 https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#tools remark-lint:double-link

links with blob/main/ in the path are accepted.
example:
- [General cheat sheets](https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/blob/main/#general-cheat-sheets)

and links with direkt link ending with hash are marked as double link
example 2:
- [Active Directory](https://github.com/ByteSnipers/awesome-pentest-cheat-sheets/#active-directory)

the last link from is a valid html link, but awesome-lint can not validate it. Is that the expected behaviour of the tool?

@VladimirAlexiev
Copy link

I want to second this: links with different fragment (after the hash) should not be counted as duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants