Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to pass URL in config? #61

Open
freddy-daniel opened this issue Apr 5, 2019 · 8 comments
Open

Is it possible to pass URL in config? #61

freddy-daniel opened this issue Apr 5, 2019 · 8 comments

Comments

@freddy-daniel
Copy link

No description provided.

@sindresorhus
Copy link
Owner

It's not in the docs, so no, it's not currently possible. Why do you need it? What problem would it solve?

@freddy-daniel
Copy link
Author

It's not in the docs, so no, it's not currently possible. Why do you need it? What problem would it solve?

It's necessary to detect my server is running or not. We cannot relay on connection with google.com. Because if your ISP allow only google.com. This entire module will fail it's purpose.

@sindresorhus
Copy link
Owner

We used to support a hostnames option, but it was removed in 302d8e5. I think we should bring it back, but only try the those hostnames if all the 3 current checks fail.

@silverwind Thoughts?

@ayalpani
Copy link

Yes, please. I need this option too. Thanks!

@freddy-daniel
Copy link
Author

It's a good news

@deadcoder0904
Copy link

@sindresorhus i'd like to take this one :)

@sindresorhus
Copy link
Owner

@deadcoder0904 Go ahead :) Don't forget to add tests and docs (readme + index.d.ts).

@pegasuspect
Copy link

@freddy-daniel You can use is-reachable pacakge: https://www.npmjs.com/package/is-reachable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants