Skip to content

Performance regression in Get<> #954

@panrafal

Description

@panrafal

After updating to the latest version I saw a huge, 50x performance regression in the type that uses Get<> underneath. The difference was measured by typescript tracing.

I don't have a reproduction, but the only commit within the last release that touches this place is this one:
986faba by @Emiyaaaaa

Looking at the change, it's reasonable it caused a slow down, as TS needs to call Path twice now. In my case, the object structure is pretty huge.
As extends string[] is much wider, why this is needed?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions