[Bug] Diffview somehow doesn't restore buffer local keymaps on close #442
Comments
|
Should I open another issue, or is the following behavior similar enough to this original issue description:
vim.keymap.set('n', '<leader>JJ', function()
print 'registering leader>ca'
local buf = vim.api.nvim_get_current_buf()
vim.keymap.set('n', '<leader>ca', function()
print 'code action ...'
-- vim.lsp.buf.code_action()
end, { buffer = buf, desc = '[C]ode [A]ction' })
end)
I find this behavior confusing since reading the I could try to look into this and figure out a fix if nobody else is. NOTE: perhaps it's not possible to fix this due to limitations of buffer local keymaps? nvim apis would need to support the ability to restore some older buffer local keymap 🤔 ? |
|
Maybe related. When exiting diffview, which-key will still list all buffer local keybindings even though they were deleted. |
|
opened but ignored ... |
|
I briefly looked into this issue ...
It may be possible using the functions So prior to calling Then restore all the keymaps from that table with
Would you please point me to the relevant sections where this is done? |
Description
I have this keymaps setting for buffer on lsp attach
and my diffview config in the minimal config section below.
Whenever I enter diffview using DiffviewOpen, then focus the cursor on all available windows (file panel, and 2 diff windows) then close it either with
tabcorDiffviewClose. Somehow my<leader>ekeymap set above disappear.Expected behavior
Diffview should restore buffer keymaps
Actual behavior
Seems like diffview override my buffer keymap
<leader>eto focus file panel action, but not restoring it on close.Steps to reproduce
<leader>eto buffer:nmap <buffer> <leader>e :lua vim.notify("test")<CR>DiffviewOpenDiffviewCloseHealth check
Output of
:checkhealth diffviewLog info
Relevant info from
:DiffviewLogNeovim version
Operating system and version
Linux 6.2.0-36-generic x86_64 GNU/Linux
Minimal config
{ 'sindrets/diffview.nvim', cmd = { 'DiffviewOpen', 'DiffviewFileHistory' }, config = function() local actions = require('diffview.actions') require('diffview').setup({ enhanced_diff_hl = false, use_icons = false, show_help_hints = false, signs = { fold_closed = ' ', fold_open = ' ', done = '✓', }, file_panel = { listing_style = 'tree', -- listing_style = 'list', -- win_config = { -- position = 'bottom', -- height = 16, -- type = 'float' -- }, }, -- https://github.com/sindrets/diffview.nvim/issues/143 hooks = { diff_buf_win_enter = function(bufnr, winid, ctx) vim.opt_local.signcolumn = 'no' end, view_enter = function() require('barbecue.ui').toggle(false) end, view_leave = function() require('barbecue.ui').toggle(true) end, }, -- https://github.com/sindrets/diffview.nvim/issues/348 -- view = { -- default = { -- winbar_info = true, -- }, -- file_history = { -- winbar_info = true, -- }, -- }, keymaps = { -- disable_defaults = false, view = { -- { 'n', 'q', '<CMD>tabclose<CR>', { desc = 'Close' } }, { 'n', '<C-q>', '<CMD>DiffviewClose<CR>', { desc = 'Close' } }, { 'n', 'q', '<CMD>DiffviewClose<CR>', { desc = 'Close' } }, { 'n', 'J', actions.scroll_view(1), { desc = 'Scroll Down' } }, { 'n', 'K', actions.scroll_view(-1), { desc = 'Scroll Up' } }, }, file_panel = { -- { 'n', 'q', '<CMD>tabclose<CR>', { desc = 'Close' } }, { 'n', '<C-q>', '<CMD>DiffviewClose<CR>', { desc = 'Close' } }, { 'n', 'q', '<CMD>DiffviewClose<CR>', { desc = 'Close' } }, { 'n', 'J', actions.scroll_view(1), { desc = 'Scroll Down' } }, { 'n', 'K', actions.scroll_view(-1), { desc = 'Scroll Up' } }, }, file_history_panel = { -- { 'n', 'q', '<CMD>tabclose<CR>', { desc = 'Close' } }, { 'n', '<C-q>', '<CMD>DiffviewClose<CR>', { desc = 'Close' } }, { 'n', 'q', '<CMD>DiffviewClose<CR>', { desc = 'Close' } }, { 'n', 'J', actions.scroll_view(1), { desc = 'Scroll Down' } }, { 'n', 'K', actions.scroll_view(-1), { desc = 'Scroll Up' } }, } } }) end },The text was updated successfully, but these errors were encountered: