Skip to content

Return exit code 0 on failure #116

@GuillaumeDesforges

Description

@GuillaumeDesforges

Description of the bug

Calling CLI tap-facebook returns exit code 0 even when it fails.

Expected behavior

Failed call should return exit code 1.

This is important for instance when calling the tool from airflow: airflow thinks the task succeeded when it did not.

Investigation

This is caused by litl/backoff#72

Proposal

Set on_giveup to a function raising an exception.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions