Multiple ID Types Support #46
Open
+157
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The tap currently cannot support multiple data types in the
_idfield forFULL_TABLEreplication, due to the behavior of MongoDB when comparing differing types (e.g., ObjectId and String). In this case it returnsfalsefor both less than and greater than, effectively filtering out the_idsof the differing type from the max_idduring full table sync.This PR contains a broken test that should be fixed by the solution to this issue, in a way that is generic for all users of mongodb and tap-mongodb.
QA steps
Risks
Relatively high, this code is hit by a lot of users of the tap.
Rollback steps