Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion about configuration confusion #400

Open
rulrok opened this issue May 9, 2024 · 0 comments
Open

Suggestion about configuration confusion #400

rulrok opened this issue May 9, 2024 · 0 comments

Comments

@rulrok
Copy link

rulrok commented May 9, 2024

I am setting up a library project and wanted to use the appropriate semver versioning and ensure the build breaks if a binary incompatible version is generated yet the semver is violated.

I initially configured my project with these two flags enabled, because I thought one was a complement of the other:
image

I thought that breakBuildOnBinaryIncompatibleModifications was the initially resonable flag that I need, and upon that, breakBuildBasedOnSemanticVersioning would complement the previous behaviour.

Then, I made changes and the building kept breaking even though I was bumping the major version.

After disabling the breakBuildOnBinaryIncompatibleModifications and leaving only breakBuildBasedOnSemanticVersioning, I realized it worked as expected.

Thus, it seems to me that they are Mutually exclusive options, and the plugin could either A) not allow me to configure in such a way, or B) at least giving me a warn message.

For suggestion A, maybe the setting could be something like:

<configuration>
    <breakBuildCriteria>
        source|binary|semver|zero
    </breakBuildCriteria>
</configuration>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant