Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default compatibility should be with CommonRLInterface #15

Open
ancorso opened this issue Jan 28, 2024 · 0 comments
Open

Default compatibility should be with CommonRLInterface #15

ancorso opened this issue Jan 28, 2024 · 0 comments

Comments

@ancorso
Copy link
Collaborator

ancorso commented Jan 28, 2024

The package was originally designed to work with a handful of POMDPs from the POMDPs.jl ecosystem. Now that it is more general, we should probably change the design so that it assumes a problem conforms to the CommonRLInterface and not an POMDP/MDP interface. We can easily construct a CommonRLInterface from the POMDP or MDP (thats effectively what is happening here:

if sampler.mdp isa POMDP
).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant