Image Scaling only works if width is given

[yanbreu]

At the moment if you use the Sitegeist.Kaleidoscope:AssetImageSource FusionObject and only parse a height value the scaling for the srcset is not calculating correctly. But the src is done right.
On the other side if only a width is given everything works like expected.

example:

<img
  srcset="http://localhost:8000/[...]-6600x3303-6600x512.jpg 1x,
    http://localhost:8000/[...]-6600x3303-6600x512.jpg 2x, 
    http://localhost:8000/[...]6600x3303-6600x512.jpg 3x"
  src="http://localhost:8000/[...]6600x3303-1023x512.jpg" >

Way to fix:
https://github.com/sitegeist/Sitegeist.Kaleidoscope/blob/master/Classes/EelHelpers/AssetImageSourceHelper.php#L73
Instant of } else { replace it with } else if (!$this->targetHeight) {.

Or is there any reason to don't do it?

Edit: I think it's related to this PR #1.

[mficzel]

Is this still the case in recent versions like 3.2. This part was adjusted befiore and i know similar issues were solved.

[jonnitto]

@yanbreu is this now solved? If yes, it would be great to close this issue