clippy warnings (sigp#136)

Author: divagant-martian

examples/simple_server.rs

@@ -46,7 +46,7 @@ async fn main() {
         let mut builder = enr::EnrBuilder::new("v4");
         // if an IP was specified, use it
         if let Some(external_address) = address {
-            builder.ip4(external_address.into());
+            builder.ip4(external_address);
         }
         // if a port was specified, use it
         if std::env::args().nth(2).is_some() {

src/error.rs

@@ -47,7 +47,7 @@ impl From<std::io::Error> for Discv5Error {
     }
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 /// Types of packet errors.
 pub enum PacketError {
     /// The packet type is unknown.
@@ -70,7 +70,7 @@ pub enum PacketError {
     InvalidEnr(DecoderError),
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 #[non_exhaustive]
 pub enum ResponseError {
     /// The channel used to send the response has already been closed.
@@ -89,7 +89,7 @@ impl fmt::Display for ResponseError {
 
 impl std::error::Error for ResponseError {}
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum RequestError {
     /// The request timed out.
     Timeout,
@@ -113,7 +113,7 @@ pub enum RequestError {
     EntropyFailure(&'static str),
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum QueryError {
     /// The discv5 service is not currently running.
     ServiceNotStarted,

src/handler/mod.rs

@@ -103,7 +103,7 @@ pub enum HandlerIn {
 }
 
 /// Messages sent between a node on the network and `Handler`.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum HandlerOut {
     /// A session has been established with a node.
     ///
@@ -139,7 +139,7 @@ pub enum ConnectionDirection {
 
 /// A reference for the application layer to send back when the handler requests any known
 /// ENR for the NodeContact.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub struct WhoAreYouRef(pub NodeAddress, MessageNonce);
 
 #[derive(Debug)]

src/ipmode.rs

@@ -5,7 +5,7 @@ use std::net::SocketAddr;
 /// Sets the socket type to be established and also determines the type of ENRs that we will store
 /// in our routing table.
 /// We store ENR's that have a `get_contractable_addr()` based on the `IpMode` set.
-#[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum IpMode {
     /// IPv4 only. This creates an IPv4 only UDP socket and will only store ENRs in the local
     /// routing table if they contain a contactable IPv4 address.

src/packet/mod.rs

@@ -72,7 +72,7 @@ impl AsRef<[u8]> for ChallengeData {
     }
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub struct Packet {
     /// Random data unique to the packet.
     pub iv: u128,
@@ -82,7 +82,7 @@ pub struct Packet {
     pub message: Vec<u8>,
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub struct PacketHeader {
     /// The nonce of the associated message
     pub message_nonce: MessageNonce,
@@ -106,7 +106,7 @@ impl PacketHeader {
     }
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum PacketKind {
     /// An ordinary message.
     Message {

src/rpc.rs

@@ -34,7 +34,7 @@ impl RequestId {
     }
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 /// A combined type representing requests and responses.
 pub enum Message {
     /// A request, which contains its [`RequestId`].
@@ -43,7 +43,7 @@ pub enum Message {
     Response(Response),
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 /// A request sent between nodes.
 pub struct Request {
     /// The [`RequestId`] of the request.
@@ -52,7 +52,7 @@ pub struct Request {
     pub body: RequestBody,
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 /// A response sent in response to a [`Request`]
 pub struct Response {
     /// The [`RequestId`] of the request that triggered this response.
@@ -61,7 +61,7 @@ pub struct Response {
     pub body: ResponseBody,
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum RequestBody {
     /// A PING request.
     Ping {
@@ -90,7 +90,7 @@ pub enum RequestBody {
     TopicQuery { topic: TopicHash },
 }
 
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum ResponseBody {
     /// A PONG response.
     Pong {