Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New way to visually compare two plots #194

Open
gustavdelius opened this issue Jun 22, 2021 · 1 comment
Open

New way to visually compare two plots #194

gustavdelius opened this issue Jun 22, 2021 · 1 comment
Labels
enhancement New feature requests or suggestions for enhancement of existing features plots Issue relates to plotting functionality

Comments

@gustavdelius
Copy link
Member

The widget_toggle() and widget_slide() functions from the vdiffr package have been removed from that package. so we need a new way to compare two plots visually. We might use the diffviewer package that vdiffr has switched to. For now I am just copying out the corresponding section in the plotting vignette.
@gustavdelius gustavdelius added enhancement New feature requests or suggestions for enhancement of existing features plots Issue relates to plotting functionality labels Jun 22, 2021
gustavdelius added a commit that referenced this issue Jun 22, 2021
@gustavdelius
Comment out the section of the plotting vignette that uses the `vdiff…
4512115 
…r` package, because this package now no longer provides the fnctions we need, see #194
@gustavdelius gustavdelius mentioned this issue Jul 17, 2022
Open
@gustavdelius
Copy link
Member Author

The diffviewer package is easy enough to use, see https://diffviewer.r-lib.org/reference/visual_diff.html. We just need to save the two plots in temporary files with ggsave() and then call diffviewer:::visual_diff() with the filenames.

To make this really useful we should also fix #250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature requests or suggestions for enhancement of existing features plots Issue relates to plotting functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gustavdelius