Skip to content

fix(skill-development): use imperative form in workflow reference#45

Merged
sjnims merged 1 commit intomainfrom
fix/skill-development-second-person
Dec 8, 2025
Merged

fix(skill-development): use imperative form in workflow reference#45
sjnims merged 1 commit intomainfrom
fix/skill-development-second-person

Conversation

@sjnims
Copy link
Owner

@sjnims sjnims commented Dec 8, 2025

Summary

  • Fix second-person usage in references/skill-creation-workflow.md
  • Change "the directories you actually need" → "the directories actually needed"
  • Ensures the skill follows its own writing style guidelines (imperative form, not second person)

Test plan

  • Verify markdown renders correctly
  • Confirm no other second-person violations remain in the file

🤖 Generated with Claude Code

Replace second-person "you actually need" with imperative form
"actually needed" to follow the skill's own writing style guidelines.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
Copy link

claude bot commented Dec 8, 2025

Claude finished @sjnims's task —— View job


PR Review Complete ✓

Tasks

  • Get PR diff to understand changes
  • Read the changed file for full context
  • Run markdownlint on changed file
  • Check for remaining second-person violations
  • Post comprehensive review

Summary

✓ Looks good - approve and merge

This is a clean, targeted fix that successfully removes a second-person violation from the workflow reference documentation.


What's Good

  1. Precise fix: Changed "you actually need" → "actually needed" (line 73)
  2. Follows guidelines: The fix aligns perfectly with the skill's own writing style guidelines (imperative form, not second person)
  3. No markdown issues: markdownlint passed with no errors
  4. Complete: No other second-person violations remain in the file (all instances of "you/your" are appropriate contextual uses)
  5. Self-consistent: The PR fixes documentation that teaches others to avoid second person - practicing what it preaches!

Verification Details

Changed line (line 73):

- Also, delete any example files and directories not needed for the skill. Create only the directories you actually need (references/, examples/, scripts/).
+ Also, delete any example files and directories not needed for the skill. Create only the directories actually needed (references/, examples/, scripts/).

Remaining "you/your" instances (all appropriate):

  • Lines 14-16: Example questions to ask users during skill discovery phase (contextually correct)
  • Lines 77, 237-239, 255, 274, 327-329: BAD examples in the "Writing Style Guide" section demonstrating what NOT to write (pedagogically necessary)

Markdown quality: ✓ All linting rules pass


Checklist Verification

From the PR test plan:

  • Markdown renders correctly (verified via markdownlint)
  • No other second-person violations remain (verified via comprehensive grep search)

Recommendation: Approve and merge. This is a straightforward documentation fix with no issues.

@sjnims sjnims self-assigned this Dec 8, 2025
@claude claude bot added documentation Improvements or additions to documentation component:skill Skills layer effort:small < 1 hour labels Dec 8, 2025
@sjnims sjnims merged commit 7d2034a into main Dec 8, 2025
8 checks passed
@sjnims sjnims deleted the fix/skill-development-second-person branch December 8, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:skill Skills layer documentation Improvements or additions to documentation effort:small < 1 hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant