-
Notifications
You must be signed in to change notification settings - Fork 2
Description
Which documentation needs improvement?
Skill documentation
Specific Location
plugins/plugin-dev/skills/hook-development/SKILL.md- Hook Events sectionplugins/plugin-dev/skills/hook-development/scripts/validate-hook-schema.sh- VALID_EVENTS array
What's unclear or missing?
The official Claude Code documentation at code.claude.com/docs/en/plugins-reference.md lists PermissionRequest as an available hook event:
Available events:
PreToolUse: Before Claude uses any toolPermissionRequest: When a permission dialog is shownPostToolUse: After Claude uses any tool- ...
However, the hook-development skill:
- Does not document PermissionRequest in the Hook Events section
- Does not include it in the description's event list: The description lists "(PreToolUse, PostToolUse, Stop, SubagentStop, SessionStart, SessionEnd, UserPromptSubmit, PreCompact, Notification)" but omits PermissionRequest
- validate-hook-schema.sh excludes it from VALID_EVENTS:
VALID_EVENTS=("PreToolUse" "PostToolUse" "UserPromptSubmit" "Stop" "SubagentStop" "SessionStart" "SessionEnd" "PreCompact" "Notification")
Question
Is the omission of PermissionRequest intentional (perhaps not supported for plugin hooks?) or an oversight?
Suggested Improvement
If intentional (not supported for plugins):
- Add a note in SKILL.md explaining that PermissionRequest is available in user settings but not for plugin hooks
- Keep validate-hook-schema.sh as-is
If oversight:
- Add PermissionRequest to the Hook Events section with documentation
- Add to the description's event list
- Add to validate-hook-schema.sh's VALID_EVENTS array
Type of issue
- Incorrect information
- Missing information
- Unclear explanation
- Broken link
- Typo or grammar
- Outdated content
- Other
Additional Context
Discovered during comprehensive skill review comparing against official Claude Code documentation. The consistent omission across both the skill content and the validation script suggests this may be intentional, but clarification would be helpful.
If PermissionRequest IS supported for plugins, this would be a valuable event to document for plugin developers who want to customize permission dialog behavior.