forked from google/jsonapi
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathembedded_structs_test.go
974 lines (894 loc) · 23.3 KB
/
embedded_structs_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
package jsonapi
import (
"bytes"
"encoding/json"
"reflect"
"testing"
)
func TestIsEmbeddedStruct(t *testing.T) {
type foo struct{}
structType := reflect.TypeOf(foo{})
stringType := reflect.TypeOf("")
if structType.Kind() != reflect.Struct {
t.Fatal("structType.Kind() is not a struct.")
}
if stringType.Kind() != reflect.String {
t.Fatal("stringType.Kind() is not a string.")
}
type test struct {
scenario string
input reflect.StructField
expectedRes bool
}
tests := []test{
test{
scenario: "success",
input: reflect.StructField{Anonymous: true, Type: structType},
expectedRes: true,
},
test{
scenario: "wrong type",
input: reflect.StructField{Anonymous: true, Type: stringType},
expectedRes: false,
},
test{
scenario: "not embedded",
input: reflect.StructField{Type: structType},
expectedRes: false,
},
}
for _, test := range tests {
res := isEmbeddedStruct(test.input)
if res != test.expectedRes {
t.Errorf(
"Scenario -> %s\nGot -> %v\nExpected -> %v\n",
test.scenario, res, test.expectedRes)
}
}
}
func TestShouldIgnoreField(t *testing.T) {
type test struct {
scenario string
input string
expectedRes bool
}
tests := []test{
test{
scenario: "opt-out",
input: annotationIgnore,
expectedRes: true,
},
test{
scenario: "no tag",
input: "",
expectedRes: false,
},
test{
scenario: "wrong tag",
input: "wrong,tag",
expectedRes: false,
},
}
for _, test := range tests {
res := shouldIgnoreField(test.input)
if res != test.expectedRes {
t.Errorf(
"Scenario -> %s\nGot -> %v\nExpected -> %v\n",
test.scenario, res, test.expectedRes)
}
}
}
func TestIsValidEmbeddedStruct(t *testing.T) {
type foo struct{}
structType := reflect.TypeOf(foo{})
stringType := reflect.TypeOf("")
if structType.Kind() != reflect.Struct {
t.Fatal("structType.Kind() is not a struct.")
}
if stringType.Kind() != reflect.String {
t.Fatal("stringType.Kind() is not a string.")
}
type test struct {
scenario string
input reflect.StructField
expectedRes bool
}
tests := []test{
test{
scenario: "success",
input: reflect.StructField{Anonymous: true, Type: structType},
expectedRes: true,
},
test{
scenario: "opt-out",
input: reflect.StructField{
Anonymous: true,
Tag: "jsonapi:\"-\"",
Type: structType,
},
expectedRes: false,
},
test{
scenario: "wrong type",
input: reflect.StructField{Anonymous: true, Type: stringType},
expectedRes: false,
},
test{
scenario: "not embedded",
input: reflect.StructField{Type: structType},
expectedRes: false,
},
}
for _, test := range tests {
res := (isEmbeddedStruct(test.input) &&
!shouldIgnoreField(test.input.Tag.Get(annotationJSONAPI)))
if res != test.expectedRes {
t.Errorf(
"Scenario -> %s\nGot -> %v\nExpected -> %v\n",
test.scenario, res, test.expectedRes)
}
}
}
// TestEmbeddedUnmarshalOrder tests the behavior of the marshaler/unmarshaler of
// embedded structs when a struct has an embedded struct w/ competing
// attributes, the top-level attributes take precedence it compares the behavior
// against the standard json package
func TestEmbeddedUnmarshalOrder(t *testing.T) {
type Bar struct {
Name int `jsonapi:"attr,Name"`
}
type Foo struct {
Bar
ID string `jsonapi:"primary,foos"`
Name string `jsonapi:"attr,Name"`
}
f := &Foo{
ID: "1",
Name: "foo",
Bar: Bar{
Name: 5,
},
}
// marshal f (Foo) using jsonapi marshaler
jsonAPIData := bytes.NewBuffer(nil)
if err := MarshalPayload(jsonAPIData, f); err != nil {
t.Fatal(err)
}
// marshal f (Foo) using json marshaler
jsonData, err := json.Marshal(f)
if err != nil {
t.Fatal(err)
}
// convert bytes to map[string]interface{} so that we can do a semantic JSON
// comparison
var jsonAPIVal, jsonVal map[string]interface{}
if err = json.Unmarshal(jsonAPIData.Bytes(), &jsonAPIVal); err != nil {
t.Fatal(err)
}
if err = json.Unmarshal(jsonData, &jsonVal); err != nil {
t.Fatal(err)
}
// get to the jsonapi attribute map
jDataMap, ok := jsonAPIVal["data"].(map[string]interface{})
if !ok {
t.Fatal("Could not parse `data`")
}
jAttrMap, ok := jDataMap["attributes"].(map[string]interface{})
if !ok {
t.Fatal("Could not parse `attributes`")
}
// compare
if !reflect.DeepEqual(jAttrMap["Name"], jsonVal["Name"]) {
t.Errorf("Got\n%s\nExpected\n%s\n", jAttrMap["Name"], jsonVal["Name"])
}
}
// TestEmbeddedMarshalOrder tests the behavior of the marshaler/unmarshaler of
// embedded structs when a struct has an embedded struct w/ competing
// attributes, the top-level attributes take precedence it compares the
// behavior against the standard json package
func TestEmbeddedMarshalOrder(t *testing.T) {
type Bar struct {
Name int `jsonapi:"attr,Name"`
}
type Foo struct {
Bar
ID string `jsonapi:"primary,foos"`
Name string `jsonapi:"attr,Name"`
}
// get a jsonapi payload w/ Name attribute of an int type
payloadWithInt, err := json.Marshal(&OnePayload{
Data: &Node{
Type: "foos",
ID: "1",
Attributes: map[string]interface{}{
"Name": 5,
},
},
})
if err != nil {
t.Fatal(err)
}
// get a jsonapi payload w/ Name attribute of an string type
payloadWithString, err := json.Marshal(&OnePayload{
Data: &Node{
Type: "foos",
ID: "1",
Attributes: map[string]interface{}{
"Name": "foo",
},
},
})
if err != nil {
t.Fatal(err)
}
// unmarshal payloadWithInt to f (Foo) using jsonapi unmarshaler; expecting an error
f := &Foo{}
if err = UnmarshalPayload(bytes.NewReader(payloadWithInt), f); err == nil {
t.Errorf("expected an error: int value of 5 should attempt to map to Foo.Name (string) and error")
}
// unmarshal payloadWithString to f (Foo) using jsonapi unmarshaler; expecting no error
f = &Foo{}
if err = UnmarshalPayload(bytes.NewReader(payloadWithString), f); err != nil {
t.Error(err)
}
if f.Name != "foo" {
t.Errorf("Got\n%s\nExpected\n%s\n", "foo", f.Name)
}
// get a json payload w/ Name attribute of an int type
bWithInt, err := json.Marshal(map[string]interface{}{
"Name": 5,
})
if err != nil {
t.Fatal(err)
}
// get a json payload w/ Name attribute of an string type
bWithString, err := json.Marshal(map[string]interface{}{
"Name": "foo",
})
if err != nil {
t.Fatal(err)
}
// unmarshal bWithInt to f (Foo) using json unmarshaler; expecting an error
f = &Foo{}
if err := json.Unmarshal(bWithInt, f); err == nil {
t.Errorf("expected an error: int value of 5 should attempt to map to Foo.Name (string) and error")
}
// unmarshal bWithString to f (Foo) using json unmarshaler; expecting no error
f = &Foo{}
if err := json.Unmarshal(bWithString, f); err != nil {
t.Error(err)
}
if f.Name != "foo" {
t.Errorf("Got\n%s\nExpected\n%s\n", "foo", f.Name)
}
}
func TestMarshalUnmarshalCompositeStruct(t *testing.T) {
type Thing struct {
ID int `jsonapi:"primary,things"`
Fizz string `jsonapi:"attr,fizz"`
Buzz int `jsonapi:"attr,buzz"`
}
type Model struct {
Thing
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
}
type test struct {
name string
payload *OnePayload
dst, expected interface{}
}
scenarios := []test{}
scenarios = append(scenarios, test{
name: "Model embeds Thing, models have no annotation overlaps",
dst: &Model{},
payload: &OnePayload{
Data: &Node{
Type: "things",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"buzz": 99,
"fizz": "fizzy",
"foo": "fooey",
},
},
},
expected: &Model{
Foo: "fooey",
Bar: "barry",
Bat: "batty",
Thing: Thing{
ID: 1,
Fizz: "fizzy",
Buzz: 99,
},
},
})
{
type Model struct {
Thing
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
Buzz int `jsonapi:"attr,buzz"` // overrides Thing.Buzz
}
scenarios = append(scenarios, test{
name: "Model embeds Thing, overlap Buzz attribute",
dst: &Model{},
payload: &OnePayload{
Data: &Node{
Type: "things",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"buzz": 99,
"fizz": "fizzy",
"foo": "fooey",
},
},
},
expected: &Model{
Foo: "fooey",
Bar: "barry",
Bat: "batty",
Buzz: 99,
Thing: Thing{
ID: 1,
Fizz: "fizzy",
},
},
})
}
{
type Model struct {
Thing
ModelID int `jsonapi:"primary,models"` //overrides Thing.ID due to primary annotation
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
Buzz int `jsonapi:"attr,buzz"` // overrides Thing.Buzz
}
scenarios = append(scenarios, test{
name: "Model embeds Thing, attribute, and primary annotation overlap",
dst: &Model{},
payload: &OnePayload{
Data: &Node{
Type: "models",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"buzz": 99,
"fizz": "fizzy",
"foo": "fooey",
},
},
},
expected: &Model{
ModelID: 1,
Foo: "fooey",
Bar: "barry",
Bat: "batty",
Buzz: 99,
Thing: Thing{
Fizz: "fizzy",
},
},
})
}
{
type Model struct {
Thing `jsonapi:"-"`
ModelID int `jsonapi:"primary,models"`
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
Buzz int `jsonapi:"attr,buzz"`
}
scenarios = append(scenarios, test{
name: "Model embeds Thing, but is annotated w/ ignore",
dst: &Model{},
payload: &OnePayload{
Data: &Node{
Type: "models",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"buzz": 99,
"foo": "fooey",
},
},
},
expected: &Model{
ModelID: 1,
Foo: "fooey",
Bar: "barry",
Bat: "batty",
Buzz: 99,
},
})
}
{
type Model struct {
*Thing
ModelID int `jsonapi:"primary,models"`
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
}
scenarios = append(scenarios, test{
name: "Model embeds pointer of Thing; Thing is initialized in advance",
dst: &Model{Thing: &Thing{}},
payload: &OnePayload{
Data: &Node{
Type: "models",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"foo": "fooey",
"buzz": 99,
"fizz": "fizzy",
},
},
},
expected: &Model{
Thing: &Thing{
Fizz: "fizzy",
Buzz: 99,
},
ModelID: 1,
Foo: "fooey",
Bar: "barry",
Bat: "batty",
},
})
}
{
type Model struct {
*Thing
ModelID int `jsonapi:"primary,models"`
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
}
scenarios = append(scenarios, test{
name: "Model embeds pointer of Thing; Thing is initialized w/ Unmarshal",
dst: &Model{},
payload: &OnePayload{
Data: &Node{
Type: "models",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"foo": "fooey",
"buzz": 99,
"fizz": "fizzy",
},
},
},
expected: &Model{
Thing: &Thing{
Fizz: "fizzy",
Buzz: 99,
},
ModelID: 1,
Foo: "fooey",
Bar: "barry",
Bat: "batty",
},
})
}
{
type Model struct {
*Thing
ModelID int `jsonapi:"primary,models"`
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
}
scenarios = append(scenarios, test{
name: "Model embeds pointer of Thing; jsonapi model doesn't assign anything to Thing; *Thing is nil",
dst: &Model{},
payload: &OnePayload{
Data: &Node{
Type: "models",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"foo": "fooey",
},
},
},
expected: &Model{
ModelID: 1,
Foo: "fooey",
Bar: "barry",
Bat: "batty",
},
})
}
{
type Model struct {
*Thing
ModelID int `jsonapi:"primary,models"`
Foo string `jsonapi:"attr,foo"`
Bar string `jsonapi:"attr,bar"`
Bat string `jsonapi:"attr,bat"`
}
scenarios = append(scenarios, test{
name: "Model embeds pointer of Thing; *Thing is nil",
dst: &Model{},
payload: &OnePayload{
Data: &Node{
Type: "models",
ID: "1",
Attributes: map[string]interface{}{
"bar": "barry",
"bat": "batty",
"foo": "fooey",
},
},
},
expected: &Model{
ModelID: 1,
Foo: "fooey",
Bar: "barry",
Bat: "batty",
},
})
}
for _, scenario := range scenarios {
t.Logf("running scenario: %s\n", scenario.name)
// get the expected model and marshal to jsonapi
buf := bytes.NewBuffer(nil)
if err := MarshalPayload(buf, scenario.expected); err != nil {
t.Fatal(err)
}
// get the node model representation and marshal to jsonapi
payload, err := json.Marshal(scenario.payload)
if err != nil {
t.Fatal(err)
}
// assert that we're starting w/ the same payload
isJSONEqual, err := isJSONEqual(payload, buf.Bytes())
if err != nil {
t.Fatal(err)
}
if !isJSONEqual {
t.Errorf("Got\n%s\nExpected\n%s\n", buf.Bytes(), payload)
}
// run jsonapi unmarshal
if err := UnmarshalPayload(bytes.NewReader(payload), scenario.dst); err != nil {
t.Fatal(err)
}
// assert decoded and expected models are equal
if !reflect.DeepEqual(scenario.expected, scenario.dst) {
t.Errorf("Got\n%#v\nExpected\n%#v\n", scenario.dst, scenario.expected)
}
}
}
func TestMarshal_duplicatePrimaryAnnotationFromEmbeddedStructs(t *testing.T) {
type Outer struct {
ID string `jsonapi:"primary,outer"`
Comment
*Post
}
o := Outer{
ID: "outer",
Comment: Comment{ID: 1},
Post: &Post{ID: 5},
}
var payloadData map[string]interface{}
// Test the standard libraries JSON handling of dup (ID) fields - it uses
// the Outer's ID
jsonData, err := json.Marshal(o)
if err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonData, &payloadData); err != nil {
t.Fatal(err)
}
if e, a := o.ID, payloadData["ID"]; e != a {
t.Fatalf("Was expecting ID to be %v, got %v", e, a)
}
// Test the JSONAPI lib handling of dup (ID) fields
jsonAPIData := new(bytes.Buffer)
if err := MarshalPayload(jsonAPIData, &o); err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonAPIData.Bytes(), &payloadData); err != nil {
t.Fatal(err)
}
data := payloadData["data"].(map[string]interface{})
id := data["id"].(string)
if e, a := o.ID, id; e != a {
t.Fatalf("Was expecting ID to be %v, got %v", e, a)
}
}
func TestMarshal_duplicateAttributeAnnotationFromEmbeddedStructs(t *testing.T) {
type Foo struct {
Count uint `json:"count" jsonapi:"attr,count"`
}
type Bar struct {
Count uint `json:"count" jsonapi:"attr,count"`
}
type Outer struct {
ID uint `json:"id" jsonapi:"primary,outer"`
Foo
Bar
}
o := Outer{
ID: 1,
Foo: Foo{Count: 1},
Bar: Bar{Count: 2},
}
var payloadData map[string]interface{}
// The standard JSON lib will not serialize either embedded struct's fields if
// a duplicate is encountered
jsonData, err := json.Marshal(o)
if err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonData, &payloadData); err != nil {
t.Fatal(err)
}
if _, found := payloadData["count"]; found {
t.Fatalf("Was not expecting to find the `count` key in the JSON")
}
// Test the JSONAPI lib handling of dup (attr) fields
jsonAPIData := new(bytes.Buffer)
if err := MarshalPayload(jsonAPIData, &o); err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonAPIData.Bytes(), &payloadData); err != nil {
t.Fatal(err)
}
data := payloadData["data"].(map[string]interface{})
if _, found := data["attributes"]; found {
t.Fatal("Was not expecting to find any `attributes` in the JSON API")
}
}
func TestMarshal_duplicateAttributeAnnotationFromEmbeddedStructsPtrs(t *testing.T) {
type Foo struct {
Count uint `json:"count" jsonapi:"attr,count"`
}
type Bar struct {
Count uint `json:"count" jsonapi:"attr,count"`
}
type Outer struct {
ID uint `json:"id" jsonapi:"primary,outer"`
*Foo
*Bar
}
o := Outer{
ID: 1,
Foo: &Foo{Count: 1},
Bar: &Bar{Count: 2},
}
var payloadData map[string]interface{}
// The standard JSON lib will not serialize either embedded struct's fields if
// a duplicate is encountered
jsonData, err := json.Marshal(o)
if err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonData, &payloadData); err != nil {
t.Fatal(err)
}
if _, found := payloadData["count"]; found {
t.Fatalf("Was not expecting to find the `count` key in the JSON")
}
// Test the JSONAPI lib handling of dup (attr) fields
jsonAPIData := new(bytes.Buffer)
if err := MarshalPayload(jsonAPIData, &o); err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonAPIData.Bytes(), &payloadData); err != nil {
t.Fatal(err)
}
data := payloadData["data"].(map[string]interface{})
if _, found := data["attributes"]; found {
t.Fatal("Was not expecting to find any `attributes` in the JSON API")
}
}
func TestMarshal_duplicateAttributeAnnotationFromEmbeddedStructsMixed(t *testing.T) {
type Foo struct {
Count uint `json:"count" jsonapi:"attr,count"`
}
type Bar struct {
Count uint `json:"count" jsonapi:"attr,count"`
}
type Outer struct {
ID uint `json:"id" jsonapi:"primary,outer"`
*Foo
Bar
}
o := Outer{
ID: 1,
Foo: &Foo{Count: 1},
Bar: Bar{Count: 2},
}
var payloadData map[string]interface{}
// The standard JSON lib will not serialize either embedded struct's fields if
// a duplicate is encountered
jsonData, err := json.Marshal(o)
if err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonData, &payloadData); err != nil {
t.Fatal(err)
}
if _, found := payloadData["count"]; found {
t.Fatalf("Was not expecting to find the `count` key in the JSON")
}
// Test the JSONAPI lib handling of dup (attr) fields; it should serialize
// neither
jsonAPIData := new(bytes.Buffer)
if err := MarshalPayload(jsonAPIData, &o); err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonAPIData.Bytes(), &payloadData); err != nil {
t.Fatal(err)
}
data := payloadData["data"].(map[string]interface{})
if _, found := data["attributes"]; found {
t.Fatal("Was not expecting to find any `attributes` in the JSON API")
}
}
func TestMarshal_duplicateFieldFromEmbeddedStructs_serializationNameDiffers(t *testing.T) {
type Foo struct {
Count uint `json:"foo-count" jsonapi:"attr,foo-count"`
}
type Bar struct {
Count uint `json:"bar-count" jsonapi:"attr,bar-count"`
}
type Outer struct {
ID uint `json:"id" jsonapi:"primary,outer"`
Foo
Bar
}
o := Outer{
ID: 1,
Foo: Foo{Count: 1},
Bar: Bar{Count: 2},
}
var payloadData map[string]interface{}
// The standard JSON lib will both the fields since their annotation name
// differs
jsonData, err := json.Marshal(o)
if err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonData, &payloadData); err != nil {
t.Fatal(err)
}
fooJSON, fooFound := payloadData["foo-count"]
if !fooFound {
t.Fatal("Was expecting to find the `foo-count` key in the JSON")
}
if e, a := o.Foo.Count, fooJSON.(float64); e != uint(a) {
t.Fatalf("Was expecting the `foo-count` value to be %v, got %v", e, a)
}
barJSON, barFound := payloadData["bar-count"]
if !barFound {
t.Fatal("Was expecting to find the `bar-count` key in the JSON")
}
if e, a := o.Bar.Count, barJSON.(float64); e != uint(a) {
t.Fatalf("Was expecting the `bar-count` value to be %v, got %v", e, a)
}
// Test the JSONAPI lib handling; it should serialize both
jsonAPIData := new(bytes.Buffer)
if err := MarshalPayload(jsonAPIData, &o); err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonAPIData.Bytes(), &payloadData); err != nil {
t.Fatal(err)
}
data := payloadData["data"].(map[string]interface{})
attributes := data["attributes"].(map[string]interface{})
fooJSONAPI, fooFound := attributes["foo-count"]
if !fooFound {
t.Fatal("Was expecting to find the `foo-count` attribute in the JSON API")
}
if e, a := o.Foo.Count, fooJSONAPI.(float64); e != uint(e) {
t.Fatalf("Was expecting the `foo-count` attrobute to be %v, got %v", e, a)
}
barJSONAPI, barFound := attributes["bar-count"]
if !barFound {
t.Fatal("Was expecting to find the `bar-count` attribute in the JSON API")
}
if e, a := o.Bar.Count, barJSONAPI.(float64); e != uint(e) {
t.Fatalf("Was expecting the `bar-count` attrobute to be %v, got %v", e, a)
}
}
func TestMarshal_embeddedStruct_providesDuplicateAttr(t *testing.T) {
type Foo struct {
Number uint `json:"count" jsonapi:"attr,count"`
}
type Outer struct {
Foo
ID uint `json:"id" jsonapi:"primary,outer"`
Count uint `json:"count" jsonapi:"attr,count"`
}
o := Outer{
ID: 1,
Count: 1,
Foo: Foo{Number: 5},
}
var payloadData map[string]interface{}
// The standard JSON lib will take the count annotated field from the Outer
jsonData, err := json.Marshal(o)
if err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonData, &payloadData); err != nil {
t.Fatal(err)
}
if e, a := o.Count, payloadData["count"].(float64); e != uint(a) {
t.Fatalf("Was expecting a JSON `count` of %v, got %v", e, a)
}
// In JSON API the handling should be that the Outer annotated count field is
// serialized into `attributes`
jsonAPIData := new(bytes.Buffer)
if err := MarshalPayload(jsonAPIData, &o); err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonAPIData.Bytes(), &payloadData); err != nil {
t.Fatal(err)
}
data := payloadData["data"].(map[string]interface{})
attributes := data["attributes"].(map[string]interface{})
if e, a := o.Count, attributes["count"].(float64); e != uint(a) {
t.Fatalf("Was expecting a JSON API `count` attribute of %v, got %v", e, a)
}
}
func TestMarshal_embeddedStructPtr_providesDuplicateAttr(t *testing.T) {
type Foo struct {
Number uint `json:"count" jsonapi:"attr,count"`
}
type Outer struct {
*Foo
ID uint `json:"id" jsonapi:"primary,outer"`
Count uint `json:"count" jsonapi:"attr,count"`
}
o := Outer{
ID: 1,
Count: 1,
Foo: &Foo{Number: 5},
}
var payloadData map[string]interface{}
// The standard JSON lib will take the count annotated field from the Outer
jsonData, err := json.Marshal(o)
if err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonData, &payloadData); err != nil {
t.Fatal(err)
}
if e, a := o.Count, payloadData["count"].(float64); e != uint(a) {
t.Fatalf("Was expecting a JSON `count` of %v, got %v", e, a)
}
// In JSON API the handling should be that the Outer annotated count field is
// serialized into `attributes`
jsonAPIData := new(bytes.Buffer)
if err := MarshalPayload(jsonAPIData, &o); err != nil {
t.Fatal(err)
}
if err := json.Unmarshal(jsonAPIData.Bytes(), &payloadData); err != nil {
t.Fatal(err)
}
data := payloadData["data"].(map[string]interface{})
attributes := data["attributes"].(map[string]interface{})
if e, a := o.Count, attributes["count"].(float64); e != uint(a) {
t.Fatalf("Was expecting a JSON API `count` attribute of %v, got %v", e, a)
}
}
// TODO: test permutation of relations with embedded structs