Skip to content

Commit a69058d

Browse files
committed
Fixes #1804 - Fix the default hosts for tcpListener and tcpConnector.
1 parent f40c69f commit a69058d

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

python/skupper_router/management/skrouter.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@
10801080
"host": {
10811081
"description":"A host name, IPV4 or IPV6 literal, or the empty string. The empty string listens on all local addresses. A host name listens on all addresses associated with the name. An IPV6 literal address (or wildcard '[::]') listens only for IPV6. An IPV4 literal address (or wildcard '0.0.0.0') listens only for IPV4.",
10821082
"type": "string",
1083-
"default": "0.0.0.0",
1083+
"default": "",
10841084
"create": true
10851085
},
10861086
"backlog": {
@@ -1160,6 +1160,7 @@
11601160
},
11611161
"host": {
11621162
"description":"IP address: ipv4 or ipv6 literal or a host name",
1163+
"default": "127.0.0.1",
11631164
"type": "string",
11641165
"create": true
11651166
},

src/adaptors/amqp/server_config.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,9 @@ static void load_strip_annotations(qd_server_config_t *config, const char* strip
7575
}
7676
}
7777

78-
79-
/**
80-
* Since both the host and the addr have defaults of 127.0.0.1, we will have to use the non-default wherever it is
81-
* available.
82-
*/
8378
static void set_config_host(qd_server_config_t *config, qd_entity_t* entity)
8479
{
85-
config->host = qd_entity_opt_string(entity, "host", 0);
86-
87-
assert(config->host);
80+
config->host = qd_entity_get_string(entity, "host");
8881

8982
int hplen = strlen(config->host) + strlen(config->port) + 2;
9083
config->host_port = malloc(hplen);

0 commit comments

Comments
 (0)