Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a credentials reference in VideoPickerValue #6

Open
abjerner opened this issue Oct 5, 2021 · 0 comments
Open

Expose a credentials reference in VideoPickerValue #6

abjerner opened this issue Oct 5, 2021 · 0 comments
Assignees
Labels
type/feature New feature or request umbraco/v8

Comments

@abjerner
Copy link
Member

abjerner commented Oct 5, 2021

If we later need to fetch additional information about a saved video, we may need to also save a reference to the credentials that were originally used for fetching the video.

Normally an instance of VideoPickerValue would be serialized as:

{
  "provider": {
    "alias": "providerAlias",
    "name": "Provider Name"
  },
  "details": { },
  "embed": { },
  "html": "..."
}

We already save a reference about the provider, but a single solutions may use multiple accounts (credentials) of a given provider.

Saving a reference to the credentials would help tracing back with credentials that were used for fetching the video details. Since we shouldn't save or expose any sensitive information about the credentials, the format could look something like this:

{
  "provider": {
    "alias": "providerAlias",
    "name": "Provider Name"
  },
  "credentials": {
    "id": "fda08a63-57a8-4eb2-8131-d5efb7cd0302"
  },
  "details": { },
  "embed": { },
  "html": "..."
}
@abjerner abjerner added the type/feature New feature or request label Oct 5, 2021
@abjerner abjerner self-assigned this Oct 5, 2021
abjerner added a commit that referenced this issue Oct 5, 2021
Whenever we save the details about a video, it may be useful to also save a reference to the credentials that were used for retrieving the video - eg. if we later need to fetch additional information about the video.

Implements #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature New feature or request umbraco/v8
Projects
None yet
Development

No branches or pull requests

1 participant