Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky scanner test panics #211

Open
gz-c opened this issue Feb 9, 2018 · 4 comments
Open

Flaky scanner test panics #211

gz-c opened this issue Feb 9, 2018 · 4 comments
Labels

Comments

@gz-c
Copy link
Member

gz-c commented Feb 9, 2018

https://travis-ci.org/skycoin/teller/builds/339379493

panic: send on closed channel

goroutine 24 [running]:
github.com/skycoin/teller/src/scanner.(*BaseScanner).processDeposit(0xc42025c5a0, 0x87e3a4, 0x3, 0xc4211303c0, 0x22, 0x2eebb80, 0x396c6, 0xc420d21180, 0x40, 0x0, ...)
	github.com/skycoin/teller/src/scanner/_test/_obj_test/base_scanner.go:119 +0x363
github.com/skycoin/teller/src/scanner.(*BaseScanner).Run.func3(0xc4210f12d0, 0xc4202300a0, 0xc42025c5a0)
	github.com/skycoin/teller/src/scanner/_test/_obj_test/base_scanner.go:364 +0x287
created by github.com/skycoin/teller/src/scanner.(*BaseScanner).Run
	github.com/skycoin/teller/src/scanner/_test/_obj_test/base_scanner.go:352 +0x82c
FAIL	github.com/skycoin/teller/src/scanner	6.841s
make: *** [test] Error 1
@gz-c gz-c added the bug label Feb 9, 2018
@stgleb
Copy link

stgleb commented Feb 15, 2018

Cannot reproduce, looks like tests are fixed on CI

@gz-c
Copy link
Member Author

gz-c commented Feb 16, 2018

That's why its flaky, only happens rarely

@therealssj
Copy link
Contributor

#229
fixed in this?

@gz-c
Copy link
Member Author

gz-c commented Mar 15, 2018

not sure. if it was related to the race condition with the logger, then possibly. the other race conditions were in the tests themselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants