Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toPolyLines wrong type, is currently information.Polyline[] but toPolyLines returns { bbox, polylines } #133

Open
AndreLeBlanc opened this issue Jun 18, 2023 · 0 comments

Comments

@AndreLeBlanc
Copy link

AndreLeBlanc commented Jun 18, 2023

When using the library to write a typescript program to estimate lengths of entities, I came across the following:

  return { bbox, polylines }

in the toPolyLines function

Yet in the types file we see:

  toPolylines(): Information.Polyline[];

Proposed solution:

 {bbox: bbox, polylines: Information.Polyline[]};
kriffe added a commit to kriffe/DefinitelyTyped that referenced this issue Sep 9, 2023
typescript-bot pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this issue Sep 21, 2023
…y type and polyline exports type corrected by @kriffe

* fix: Entity type corrected to non capital letters and valid Entity instead of string

* fix: Corrected type for toPolylines export to match actual export

Fixing skymakerolof/dxf#133

* fix: Corrected polyline export in helper too

* Updated dxf tests

* Added common Line entity test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant