Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: change pyyaml requirement to >= 6? #2285

Closed
concretevitamin opened this issue Jul 21, 2023 · 4 comments
Closed

setup.py: change pyyaml requirement to >= 6? #2285

concretevitamin opened this issue Jul 21, 2023 · 4 comments
Labels

Comments

@concretevitamin
Copy link
Member

concretevitamin commented Jul 21, 2023

That said, the dependency issue may occur for folks who already have newer version of kubernetes installed. As suggested in review comment, can you also try pyyaml >=6.0.1?

Originally posted by @romilbhardwaj in #2283 (review)

Pinning pyyaml<=5.3.1 was a temp fix. We should test pinning it to be >= 6 or the like

@jmif
Copy link

jmif commented Aug 30, 2023

Running into this with https://github.com/mosaicml/composer, would be great to support 6.0+. Is upgrading + running tests sufficient or is there more testing work required? May be able to help here.

@concretevitamin
Copy link
Member Author

We'd love your help to test 6.0+ @jmif! Please see here: https://github.com/skypilot-org/skypilot/blob/master/CONTRIBUTING.md#testing

Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 29, 2023
@romilbhardwaj
Copy link
Collaborator

We now use pyyaml > 3.13, != 5.4.* as the constraint. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants