-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py: change pyyaml requirement to >= 6? #2285
Comments
Running into this with https://github.com/mosaicml/composer, would be great to support 6.0+. Is upgrading + running tests sufficient or is there more testing work required? May be able to help here. |
We'd love your help to test 6.0+ @jmif! Please see here: https://github.com/skypilot-org/skypilot/blob/master/CONTRIBUTING.md#testing |
This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
We now use |
That said, the dependency issue may occur for folks who already have newer version of
kubernetes
installed. As suggested in review comment, can you also trypyyaml >=6.0.1
?Originally posted by @romilbhardwaj in #2283 (review)
Pinning
pyyaml<=5.3.1
was a temp fix. We should test pinning it to be >= 6 or the likeCython<3
yaml/pyyaml#728The text was updated successfully, but these errors were encountered: