separate out optimizer dryruns to its separate group #7950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizer Dryrun tests can be flaky (with flakiness lasting for up to several hours at a time). Usually the method to deal with such issues is to mark the specific optimizer test as not required temporarily and rerun all other failed jobs and merge the PR in.
The problem here is that once a single test in a group fails, all other tests in the group are automatically cancelled. This usually means rerunning all failed jobs do not help because one of the optimizer tests will fail again, causing rest of the tests to be cancelled. The current workaround is to rerun each test (excluding the failed optimizer tests) one at a time which is unnecessarily time consuming.
This PR separates the optimizer tests to a separate test group so other tests can be rerun independently of optimizer test failures.
Since this introduces some code duplication, I factor out the common steps into a separate action.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)