Skip to content

Conversation

@SeungjinYang
Copy link
Collaborator

@SeungjinYang SeungjinYang commented Nov 13, 2025

Optimizer Dryrun tests can be flaky (with flakiness lasting for up to several hours at a time). Usually the method to deal with such issues is to mark the specific optimizer test as not required temporarily and rerun all other failed jobs and merge the PR in.

The problem here is that once a single test in a group fails, all other tests in the group are automatically cancelled. This usually means rerunning all failed jobs do not help because one of the optimizer tests will fail again, causing rest of the tests to be cancelled. The current workaround is to rerun each test (excluding the failed optimizer tests) one at a time which is unnecessarily time consuming.

This PR separates the optimizer tests to a separate test group so other tests can be rerun independently of optimizer test failures.

Screenshot 2025-11-17 at 5 05 14 AM Screenshot 2025-11-17 at 4 49 24 AM

Since this introduces some code duplication, I factor out the common steps into a separate action.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@SeungjinYang SeungjinYang force-pushed the optimizer-section branch 2 times, most recently from 791df5c to 3222c07 Compare November 16, 2025 19:28
@SeungjinYang SeungjinYang marked this pull request as ready for review November 16, 2025 20:04
@kevinmingtarja
Copy link
Collaborator

It seems like there's a recent merge conflict, could you take a look @SeungjinYang?

Copy link
Collaborator

@zpoint zpoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@SeungjinYang SeungjinYang merged commit 846c47a into master Dec 5, 2025
29 checks passed
@SeungjinYang SeungjinYang deleted the optimizer-section branch December 5, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants