Skip to content

Conversation

@zpoint
Copy link
Collaborator

@zpoint zpoint commented Nov 27, 2025

We're reusing the VPC to avoid resource issues, but the VPC environment name on Buildkite changed, causing a nightly failure. Update the environment name to fix the problem.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@zpoint zpoint requested a review from lloyd-brown November 27, 2025 03:06
@zpoint
Copy link
Collaborator Author

zpoint commented Nov 27, 2025

/smoke-test -k test_helm_deploy_eks --aws --helm-version 1.0.0.dev20251126 --helm-package skypilot-nightly

@zpoint
Copy link
Collaborator Author

zpoint commented Nov 27, 2025

/smoke-test -k test_large_production_performance --kubernetes

@zpoint zpoint changed the title Fix test_helm_deploy_eks failure [Test] Reuse existing VPC to fix test_helm_deploy_eks failure Nov 27, 2025
Copy link
Collaborator

@lloyd-brown lloyd-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense thanks @zpoint!

@zpoint
Copy link
Collaborator Author

zpoint commented Nov 27, 2025

/smoke-test -k test_helm_deploy_eks --aws --helm-version 1.0.0.dev20251126 --helm-package skypilot-nightly

@zpoint
Copy link
Collaborator Author

zpoint commented Nov 27, 2025

/smoke-test -k test_helm_deploy_eks --aws --helm-version 1.0.0.dev20251126 --helm-package skypilot-nightly

@zpoint
Copy link
Collaborator Author

zpoint commented Nov 27, 2025

/smoke-test -k test_helm_deploy_eks --aws --helm-version 1.0.0.dev20251126 --helm-package skypilot-nightly

@zpoint
Copy link
Collaborator Author

zpoint commented Nov 27, 2025

/smoke-test -k test_helm_deploy_eks --aws --helm-version 1.0.0.dev20251126 --helm-package skypilot-nightly

@zpoint
Copy link
Collaborator Author

zpoint commented Nov 27, 2025

/smoke-test -k test_large_production_performance --kubernetes

@zpoint zpoint merged commit 60a0fac into skypilot-org:master Nov 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants