From c1f86674392e639eba7f71316034c3d2db9ed69d Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 16 Dec 2023 19:07:32 +0000 Subject: [PATCH] vuln-fix: Use HTTPS instead of HTTP to resolve deps CVE-2021-26291 This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Weakness: CWE-829: Inclusion of Functionality from Untrusted Control Sphere Severity: High CVSS: 8.1 Detection: CodeQL & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8 Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-maven-non-https-url/) & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8 Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/IfHkrYfxx?organizationId=QWxsIEdpdEh1Yg%3D%3D Co-authored-by: Moderne --- yoga-demos/yoga-demo-jaxrs-shared/pom.xml | 2 +- yoga-demos/yoga-demo-jersey-standalone/pom.xml | 2 +- yoga-demos/yoga-demo-resteasy/pom.xml | 4 ++-- yoga-demos/yoga-demo-shared/pom.xml | 6 +++--- yoga-demos/yoga-demo-springmvc/pom.xml | 6 +++--- yoga-integration/yoga-jaxrs/pom.xml | 4 ++-- yoga-integration/yoga-jersey/pom.xml | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/yoga-demos/yoga-demo-jaxrs-shared/pom.xml b/yoga-demos/yoga-demo-jaxrs-shared/pom.xml index 1f628ec8..4c3a7fb3 100644 --- a/yoga-demos/yoga-demo-jaxrs-shared/pom.xml +++ b/yoga-demos/yoga-demo-jaxrs-shared/pom.xml @@ -53,7 +53,7 @@ maven-repos Glassfish Repos - http://maven.java.net + https://maven.java.net diff --git a/yoga-demos/yoga-demo-jersey-standalone/pom.xml b/yoga-demos/yoga-demo-jersey-standalone/pom.xml index 416184f6..89e2df10 100644 --- a/yoga-demos/yoga-demo-jersey-standalone/pom.xml +++ b/yoga-demos/yoga-demo-jersey-standalone/pom.xml @@ -95,7 +95,7 @@ maven-repos Glassfish Repos - http://maven.java.net + https://maven.java.net diff --git a/yoga-demos/yoga-demo-resteasy/pom.xml b/yoga-demos/yoga-demo-resteasy/pom.xml index f9186497..305b1592 100644 --- a/yoga-demos/yoga-demo-resteasy/pom.xml +++ b/yoga-demos/yoga-demo-resteasy/pom.xml @@ -104,7 +104,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ default true @@ -120,7 +120,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ true diff --git a/yoga-demos/yoga-demo-shared/pom.xml b/yoga-demos/yoga-demo-shared/pom.xml index c903d006..278ccdc8 100755 --- a/yoga-demos/yoga-demo-shared/pom.xml +++ b/yoga-demos/yoga-demo-shared/pom.xml @@ -152,7 +152,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ default true @@ -165,7 +165,7 @@ terracotta-releases - http://www.terracotta.org/download/reflector/releases + https://www.terracotta.org/download/reflector/releases true @@ -178,7 +178,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ true diff --git a/yoga-demos/yoga-demo-springmvc/pom.xml b/yoga-demos/yoga-demo-springmvc/pom.xml index c04c7854..92b315e5 100755 --- a/yoga-demos/yoga-demo-springmvc/pom.xml +++ b/yoga-demos/yoga-demo-springmvc/pom.xml @@ -123,7 +123,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ default true @@ -144,7 +144,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ true @@ -155,7 +155,7 @@ repository.springframework.maven.milestone Spring Framework Maven Milestone Repository - http://maven.springframework.org/milestone + https://maven.springframework.org/milestone diff --git a/yoga-integration/yoga-jaxrs/pom.xml b/yoga-integration/yoga-jaxrs/pom.xml index 3faa5c82..b96516e4 100644 --- a/yoga-integration/yoga-jaxrs/pom.xml +++ b/yoga-integration/yoga-jaxrs/pom.xml @@ -46,7 +46,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ default true @@ -62,7 +62,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ true diff --git a/yoga-integration/yoga-jersey/pom.xml b/yoga-integration/yoga-jersey/pom.xml index 1c78c90e..26a6734f 100644 --- a/yoga-integration/yoga-jersey/pom.xml +++ b/yoga-integration/yoga-jersey/pom.xml @@ -57,7 +57,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ default true @@ -73,7 +73,7 @@ jboss-public-repository-group JBoss Public Repository Group - http://repository.jboss.org/nexus/content/groups/public/ + https://repository.jboss.org/nexus/content/groups/public/ true