Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE: two implementations of Mtrx #49

Open
tjlane opened this issue Aug 27, 2020 · 1 comment
Open

ISSUE: two implementations of Mtrx #49

tjlane opened this issue Aug 27, 2020 · 1 comment

Comments

@tjlane
Copy link
Contributor

tjlane commented Aug 27, 2020

Seems like there are two class implementations of sensors.Mtrx -- I assume the second one clobbers the first which is why everything works out OK. We should probably just delete the first, but it would be good to understand why there are two first...

@valmar I suspect this was me but if you have insight let me know 👍

https://github.com/slaclab/psgeom/blob/master/psgeom/sensors.py#L674

https://github.com/slaclab/psgeom/blob/master/psgeom/sensors.py#L798
@valmar
Copy link
Collaborator

valmar commented Aug 27, 2020

Git blame says @chuckie82 ..... 😄 😄

93568d7 (yoon82 2016-11-19 20:11:20 -0800 674) class Mtrx(PixelArraySensor):
93568d7 (yoon82 2016-11-19 20:11:20 -0800 798) class Mtrx(PixelArraySensor):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valmar @tjlane